mark also coimage for the move to AbstractAlgebra

oscar-system · Apr 11, 2024 · 88dcef0 · 88dcef0
1 parent b76ce26
commit 88dcef0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/experimental/GModule/Brueckner.jl b/experimental/GModule/Brueckner.jl
@@ -1,8 +1,6 @@
 module RepPc
 using Oscar
 
-export coimage
-
 #=TODO
  - construct characters along the way as well?
  - compare characters rather than the hom_base
@@ -265,10 +263,6 @@ function brueckner(mQ::Map{<:Oscar.GAPGroup, PcGroup}; primes::Vector=[])
   return allR
 end
 
-function coimage(h::Map)
-  return quo(domain(h), kernel(h)[1])
-end
-
 """
   mp: G ->> Q
   C a F_p[Q]-module
@@ -427,5 +421,3 @@ orbits(G)
 end #module RepPc
 
 using .RepPc
-
-export coimage
diff --git a/experimental/GModule/Misc.jl b/experimental/GModule/Misc.jl
@@ -2,6 +2,7 @@ module Misc
 using Oscar
 import Base: ==, parent
 
+export coimage
 export relative_field
 
 Hecke.minpoly(a::QQBarFieldElem) = minpoly(Hecke.Globals.Qx, a)
@@ -508,6 +509,11 @@ function Oscar.direct_sum(M::AbstractAlgebra.Generic.DirectSumModule{T}, N::Abst
   return hom(M, N, cat(map(matrix, mp)..., dims = (1,2)))
 end
 
+function coimage(h::Map)
+  return quo(domain(h), kernel(h)[1])
+end
+
 end # module
 using .Misc
+export coimage
 export relative_field