[FTheoryTools] Misc inference improvements

experimental/FTheoryTools/src/HypersurfaceModels/attributes.jl

@@ -82,7 +82,7 @@ Weierstrass model over a not fully specified base -- F-theory weierstrass model
 function weierstrass_model(h::HypersurfaceModel)
   @req has_attribute(h, :weierstrass_model) "No corresponding Weierstrass model is known"
   w = get_attribute(h, :weierstrass_model)
-  if typeof(w) == String
+  if w isa String
     directory = joinpath(dirname(@__DIR__), "LiteratureModels/")
     model_indices = JSON.parsefile(directory * "model_indices.json")
     if is_base_space_fully_specified(h)

experimental/FTheoryTools/src/TateModels/constructors.jl

@@ -212,16 +212,16 @@ function Base.show(io::IO, t::GlobalTateModel)
     push!(properties_string, "not fully specified base")
   end
   if has_model_description(t)
-    push!(properties_string, "-- " * string(get_attribute(t, :model_description)))
+    push!(properties_string, "-- " * model_description(t))
     if has_model_parameters(t)
       push!(properties_string, "with parameter values (" * join(["$key = $(string(val))" for (key, val) in model_parameters(t)], ", ") * ")")
     end
   end
   if has_arxiv_id(t)
-    push!(properties_string, "based on arXiv paper " * string(get_attribute(t, :arxiv_id)))
+    push!(properties_string, "based on arXiv paper " * arxiv_id(t))
   end
   if has_arxiv_model_equation_number(t)
-    push!(properties_string, "Eq. (" * string(get_attribute(t, :arxiv_model_equation_number)) * ")")
+    push!(properties_string, "Eq. (" * arxiv_model_equation_number(t) * ")")
   end
   join(io, properties_string, " ")
 end

experimental/FTheoryTools/src/WeierstrassModels/constructors.jl

@@ -181,16 +181,16 @@ function Base.show(io::IO, w::WeierstrassModel)
     push!(properties_string, "not fully specified base")
   end
   if has_model_description(w)
-    push!(properties_string, "-- " * string(get_attribute(w, :model_description)))
+    push!(properties_string, "-- " * model_description(w))
     if has_model_parameters(w)
       push!(properties_string, "with parameter values (" * join(["$key = $(string(val))" for (key, val) in model_parameters(t)], ", ") * ")")
     end
   end
   if has_arxiv_id(w)
-    push!(properties_string, "based on arXiv paper " * string(get_attribute(w, :arxiv_id)))
+    push!(properties_string, "based on arXiv paper " * arxiv_id(w))
   end
   if has_arxiv_model_equation_number(w)
-    push!(properties_string, "Eq. (" * string(get_attribute(w, :arxiv_model_equation_number)) * ")")
+    push!(properties_string, "Eq. (" * arxiv_model_equation_number(w) * ")")
   end
   join(io, properties_string, " ")
 end