Skip to content

Commit

Permalink
Update to GAP.jl 0.11.3 resp. GAP 4.13.1 (#3688)
Browse files Browse the repository at this point in the history
Co-authored-by: ThomasBreuer <sam@math.rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
  • Loading branch information
3 people authored Sep 16, 2024
1 parent 97bc0a4 commit e5c0365
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cohomCalg_jll = "5558cf25-a90e-53b0-b813-cadaa3ae7ade"
AbstractAlgebra = "0.42.3"
AlgebraicSolving = "0.5.1"
Distributed = "1.6"
GAP = "0.10.2"
GAP = "0.11.3"
Hecke = "0.33.0"
JSON = "^0.20, ^0.21"
JSON3 = "1.13.2"
Expand Down
2 changes: 1 addition & 1 deletion src/Groups/GAPGroups.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1024,8 +1024,8 @@ julia> G = symmetric_group(5);
julia> low_index_subgroup_classes(G, 5)
3-element Vector{GAPGroupConjClass{PermGroup, PermGroup}}:
Conjugacy class of Sym(5) in G
Conjugacy class of Alt(5) in G
Conjugacy class of permutation group in G
Conjugacy class of Alt(5) in G
```
"""
function low_index_subgroup_classes(G::GAPGroup, n::Int)
Expand Down
2 changes: 1 addition & 1 deletion src/Groups/cosets.jl
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ struct SubgroupTransversal{T<: GAPGroup, S<: GAPGroup, E<: GAPGroupElem} <: Abst
X::GapObj # underlying *right* transversal in GAP
end

GAP.julia_to_gap(T::SubgroupTransversal) = T.X
GAP.julia_to_gap(T::SubgroupTransversal, d::IdDict{Any,Any} = IdDict(); recursive::Bool = false) = T.X

function Base.show(io::IO, ::MIME"text/plain", x::SubgroupTransversal)
side = x.side === :left ? "Left" : "Right"
Expand Down
8 changes: 4 additions & 4 deletions src/Groups/directproducts.jl
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ julia> elements(G)
(4,5)
(2,3)
(2,3)(4,5)
(1,2)
(1,2)(4,5)
(1,2,3)
(1,2,3)(4,5)
(1,3,2)
(1,3,2)(4,5)
(1,3)
(1,3)(4,5)
(1,2,3)
(1,2,3)(4,5)
(1,2)
(1,2)(4,5)
```
"""
function direct_product(L::AbstractVector{<:GAPGroup}; morphisms::Bool=false)
Expand Down
4 changes: 2 additions & 2 deletions src/Groups/homomorphisms.jl
Original file line number Diff line number Diff line change
Expand Up @@ -544,10 +544,10 @@ Pc group of order 6
julia> iso = isomorphism(PermGroup, G)
Group homomorphism
from pc group of order 6
to permutation group of degree 6 and order 6
to permutation group of degree 3 and order 6
julia> permutation_group(G)
Permutation group of degree 6 and order 6
Permutation group of degree 3 and order 6
julia> codomain(iso) === ans
true
Expand Down
4 changes: 2 additions & 2 deletions test/book/cornerstones/groups/actions.jlcon
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ Group homomorphism
julia> isomorphism(PermGroup, U)
Group homomorphism
from pc group of order 8
to permutation group of degree 8 and order 8
to permutation group of degree 4 and order 8

julia> permutation_group(U)
Permutation group of degree 8 and order 8
Permutation group of degree 4 and order 8

julia> for g in all_transitive_groups(degree => 3:9, !is_primitive)
h = image(optimal_perm_rep(g))[1]
Expand Down

0 comments on commit e5c0365

Please sign in to comment.