From f58d75d3a4c4be09a897abc7cd284b04ac299384 Mon Sep 17 00:00:00 2001
From: Martin Bies <MBies87@googlemail.com>
Date: Tue, 9 Apr 2024 22:18:55 +0200
Subject: [PATCH] [FtheoryTools] Add simple test for F1 hypersurface model in
 1408_4808

---
 .../LiteratureModels/Models/model1408_4808-1.json |  4 +++-
 .../FTheoryTools/test/literature_models.jl        | 15 +++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/experimental/FTheoryTools/src/LiteratureModels/Models/model1408_4808-1.json b/experimental/FTheoryTools/src/LiteratureModels/Models/model1408_4808-1.json
index 5ef7cfa2af8b..cef3b308f14e 100644
--- a/experimental/FTheoryTools/src/LiteratureModels/Models/model1408_4808-1.json
+++ b/experimental/FTheoryTools/src/LiteratureModels/Models/model1408_4808-1.json
@@ -40,7 +40,7 @@
     },
     "model_descriptors": {
         "type": "hypersurface",
-        "description": "The toric variety associated to F_1",
+        "description": "F-theory hypersurface model with fiber ambient space F_1",
         "gauge_algebra": ["0"],
         "discrete_factors": ["Z3"]
     },
@@ -57,6 +57,8 @@
         "fiber_ambient_space_max_cones": [[1, 2], [2, 3], [1, 3]],
         "fiber_ambient_space_coordinates": ["u", "v", "w"],
         "fiber_ambient_space_name": "P2",
+        "D1": [0, 1, 0],
+        "D2": [0, 0, 1],
         "hypersurface_equation": "s1*u^3 + s2*u^2*v + s3*u*v^2 + s4*v^3 + s5*u^2*w + s6*u*v*w + s7*v^2*w + s8*u*w^2 + s9*v*w^2 + s10*w^3"
     },
     "associated_models": [
diff --git a/experimental/FTheoryTools/test/literature_models.jl b/experimental/FTheoryTools/test/literature_models.jl
index 995b99f0749b..ac9a56c47487 100644
--- a/experimental/FTheoryTools/test/literature_models.jl
+++ b/experimental/FTheoryTools/test/literature_models.jl
@@ -367,3 +367,18 @@ h = literature_model(arxiv_id = "1507.05954", equation = "3.4")
   @test is_partially_resolved(h) == false
   @test string.(zero_section(h)) == ["0", "-b1", "a1"]
 end
+
+
+
+#############################################################
+# 8: Test models from F-theory on all toric hypersurfaces
+#############################################################
+
+foah1 = literature_model(arxiv_id = "1408.4808v2", equation = "3.4")
+
+@testset "Test defining data for literature model defined by model index" begin
+  @test dim(base_space(foah1)) == 3
+  @test dim(ambient_space(foah1)) == 5
+  @test is_base_space_fully_specified(foah1) == false
+  @test model_description(foah1) == "F-theory hypersurface model with fiber ambient space F_1"
+end