rename factorization -> factor

oscar-system · Apr 10, 2024 · fc72cb6 · fc72cb6
1 parent bd8ef20
commit fc72cb6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/experimental/PartitionedPermutations/src/PartitionedPermutationProducts.jl b/experimental/PartitionedPermutations/src/PartitionedPermutationProducts.jl
@@ -38,17 +38,17 @@ function *(pp_1::PartitionedPermutation, pp_2::PartitionedPermutation)
 end
 
 """
-    factorization(pp::PartitionedPermutation)
+    factor(pp::PartitionedPermutation)
 
 Return the factorization of `pp` in form of a set of 2-tuples.
 
 # Examples
 ```jldoctest
-julia> length(factorization(partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 2])))
+julia> length(factor(partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 2])))
 2
 ```
 """
-function factorization(pp::PartitionedPermutation)
+function factor(pp::PartitionedPermutation)
     size = length(upper_points(partition(pp)))
 
     product_pairs = Set{Tuple{PartitionedPermutation, PartitionedPermutation}}()

diff --git a/experimental/PartitionedPermutations/src/PartitionedPermutations.jl b/experimental/PartitionedPermutations/src/PartitionedPermutations.jl
@@ -29,7 +29,8 @@ import Oscar:
     size,
     set_partition,
     partition,
-    permutation
+    permutation,
+    factor
 
 
 export PartitionedPermutation
@@ -40,7 +41,6 @@ export permutation
 export length
 export adjusted_length
 export enumerate_partitioned_permutations
-export factorization
 
 
 include("PartitionedPermutation.jl")
@@ -56,4 +56,3 @@ export partitioned_permutation
 
 export adjusted_length
 export enumerate_partitioned_permutations
-export factorization
diff --git a/experimental/PartitionedPermutations/test/PartitionedPermu-test.jl b/experimental/PartitionedPermutations/test/PartitionedPermu-test.jl
@@ -20,10 +20,10 @@
             partitioned_permutation(perm(symmetric_group(6), [1, 2, 3, 4, 5, 6]), [1, 2, 3, 4, 5, 6])
         @test partitioned_permutation(perm(symmetric_group(3), [1, 2, 3]), [1, 2, 3]) * partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 3]) ==
             partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 2])
-        @test length(factorization(partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 2]))) == 2
-        @test length(factorization(partitioned_permutation(perm(symmetric_group(4), [2, 1, 4, 3]), [1, 1, 2, 2]))) <
-              length(factorization(partitioned_permutation(perm(symmetric_group(4), [1, 2, 3, 4]), [1, 2, 3, 4])))
-        @test length(factorization(partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 2]))) <
-              length(factorization(partitioned_permutation(perm(symmetric_group(3), [1, 2, 3]), [1, 2, 3])))
+        @test length(factor(partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 2]))) == 2
+        @test length(factor(partitioned_permutation(perm(symmetric_group(4), [2, 1, 4, 3]), [1, 1, 2, 2]))) <
+              length(factor(partitioned_permutation(perm(symmetric_group(4), [1, 2, 3, 4]), [1, 2, 3, 4])))
+        @test length(factor(partitioned_permutation(perm(symmetric_group(3), [2, 1, 3]), [1, 1, 2]))) <
+              length(factor(partitioned_permutation(perm(symmetric_group(3), [1, 2, 3]), [1, 2, 3])))
     end
 end