Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyhedralGeometry: Format most of the files #3591

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

lkastner
Copy link
Member

I am only aware of #3512 and excluded the two files being worked on there.

@lkastner lkastner marked this pull request as draft April 11, 2024 14:56
@benlorenz benlorenz added the don't squash! do not squash the commits when merging label Apr 11, 2024
@lgoettgens
Copy link
Member

lgoettgens commented Apr 11, 2024

Thanks, @lkastner, for taking care of this!

Wouldn't it be nicer for the history if the new action and formatting of the PolyhedralGeometry folder were in different PRs? If you need some formatted files to test the action with, there is already the LieAlgebras stuff you found.

@benlorenz
Copy link
Member

Wouldn't it be nicer for the history if the new action and formatting of the PolyhedralGeometry folder were in different PRs? If you need some formatted files to test the action with, there is already the LieAlgebras stuff you found.

If we make sure not to squash this PR then the commits stay separate, also with a proper merge instead of a rebase to make sure the commit for the blame-ignore-rev stays correct.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #3591 (1be61d8) into master (f7eeee6) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 89.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3591   +/-   ##
=======================================
  Coverage   81.73%   81.73%           
=======================================
  Files         573      573           
  Lines       77520    77543   +23     
=======================================
+ Hits        63359    63379   +20     
- Misses      14161    14164    +3     
Files Coverage Δ
.../PolyhedralGeometry/Cone/standard_constructions.jl 100.00% <100.00%> (ø)
src/PolyhedralGeometry/LP_file_format.jl 88.46% <100.00%> (ø)
...ometry/PolyhedralComplex/standard_constructions.jl 100.00% <100.00%> (ø)
src/PolyhedralGeometry/PolyhedralFan/properties.jl 98.33% <100.00%> (+0.05%) ⬆️
...alGeometry/PolyhedralFan/standard_constructions.jl 100.00% <100.00%> (ø)
src/PolyhedralGeometry/PolyhedralGeometry.jl 25.00% <ø> (ø)
...olyhedralGeometry/SubdivisionOfPoints/functions.jl 100.00% <100.00%> (ø)
src/PolyhedralGeometry/linear_program.jl 92.72% <100.00%> (ø)
...PolyhedralGeometry/mixed_integer_linear_program.jl 55.38% <ø> (ø)
src/PolyhedralGeometry/Cone/constructors.jl 91.11% <96.00%> (+0.41%) ⬆️
... and 14 more

@lkastner lkastner marked this pull request as ready for review April 11, 2024 19:58
@fingolfin fingolfin merged commit 70ccd14 into master Apr 12, 2024
29 checks passed
@fingolfin fingolfin deleted the lk/format/polyhedral branch April 12, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't squash! do not squash the commits when merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants