Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with empty ideals in Singular #3992

Closed
HechtiDerLachs opened this issue Aug 5, 2024 · 2 comments
Closed

Crashes with empty ideals in Singular #3992

HechtiDerLachs opened this issue Aug 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@HechtiDerLachs
Copy link
Collaborator

HechtiDerLachs commented Aug 5, 2024

To reproduce:

P, (x, y) = QQ[:x, :y]
I = ideal(P, elem_type(P)[])
radical_membership(x, I) # Boom!

Fixed in #3988 . Fixed in #3995.

It might be worthwhile to investigate this nevertheless. The crash looked really bad with memory access issues in the singular kernel. Maybe something else should also be fixed on another level? (ping @hannes14 )

@HechtiDerLachs HechtiDerLachs added the bug Something isn't working label Aug 5, 2024
@fingolfin
Copy link
Member

Resolved now but @HechtiDerLachs wanted to talked with @hannes14 to see if there is more problems with zero ideals ...

@afkafkafk13 points out that having an empty list of generators might be a problem for Singular. So maybe the code which translates our ideals into Singular ideals should also be adjusted to work with ideals with empty generators?

@hannes14 will take a look

@fingolfin fingolfin changed the title Radical membership crashes for empty ideals Crashes with empty ideals in Singular Sep 4, 2024
@thofma
Copy link
Collaborator

thofma commented Sep 25, 2024

From triage: The original issue is fixed. If we find a new error due to "empty ideals", a new issue should be created.

@lgoettgens lgoettgens removed the triage label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants