Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline FreeAssAlgebra and Hecke.AssociativeAlgebraElem #4043

Closed
lgoettgens opened this issue Aug 23, 2024 · 6 comments · Fixed by #4035
Closed

Streamline FreeAssAlgebra and Hecke.AssociativeAlgebraElem #4043

lgoettgens opened this issue Aug 23, 2024 · 6 comments · Fixed by #4035

Comments

@lgoettgens
Copy link
Member

lgoettgens commented Aug 23, 2024

At the Friday meeting today it was discussed that while @Sequenzer works on associative algebras in Oscar, we can use the opportunity to streamline the already existing things in AbstractAlgebra and Hecke (both naming and interface).
From a first look, there seems to be:

  • AbstractAlgebra.FreeAssAlgebra
  • AbstractAlgebra.FreeAssAlgElem
  • Hecke.AbstractAssociativeAlgebraElem
  • Hecke.AssociativeAlgebraElem

I haven't checked what all of them offer, what the differences are, possibilities, etc. This issue exists just to have some place for discussions.

cc @Sequenzer @thofma @micjoswig @fieker

@thofma
Copy link
Collaborator

thofma commented Aug 23, 2024

I think we can just rename FreeAssAlgebra to FreeAssociativeAlgebra and similar for the element. They have nothing else in common that would warrant an "interface".

@fieker
Copy link
Contributor

fieker commented Aug 28, 2024

@lgoettgens is promising a resolution by this afternoon... hold thumbs
(it just a renaming)

@lgoettgens
Copy link
Member Author

The renaming of the two AA types is done in Nemocas/AbstractAlgebra.jl#1779.

What remains is to rename FreeAssAlgIdeal to FreeAssociativeAlgebraIdeal. Since this would create a hell of a lot of conflicts with #4035, I would ask @Sequenzer to include this change in #4035. It should be a simple search-and-replace and adding Base.@deprecate_binding FreeAssAlgIdeal FreeAssociativeAlgebraIdeal to the bottom of deprecations.jl.

@micjoswig
Copy link
Member

Indeed, @Sequenzer please do as proposed.

What remains is to rename FreeAssAlgIdeal to FreeAssociativeAlgebraIdeal. Since this would create a hell of a lot of conflicts with #4035, I would ask @Sequenzer to include this change in #4035. It should be a simple search-and-replace and adding Base.@deprecate_binding FreeAssAlgIdeal FreeAssociativeAlgebraIdeal to the bottom of deprecations.jl.

@Sequenzer
Copy link
Collaborator

I would wait for the changes in AbstractAlgebra to propagate to OSCAR. But then I will do it.

@lgoettgens
Copy link
Member Author

It's already available as AA 0.42.3. You just need to update the compat entry in Oscar's Project.toml.

@joschmitt joschmitt linked a pull request Aug 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants