PolyhedralGeometry: minor fixes #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benlorenz
commented
Oct 29, 2024
benlorenz
commented
- fix scalar detection for tuples in facet construction
- add test
- avoid warnings from duplicate includes during testing
benlorenz
changed the title
for tuples in facet construction add test
benlorenz
force-pushed
the
bl/polyhedralmisc
branch
from
5b94909
to
aa8d4b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4253 +/- ##
=======================================
Coverage 84.60% 84.60%
=======================================
Files 640 640
Lines 85122 85124 +2
=======================================
+ Hits 72014 72020 +6
+ Misses 13108 13104 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.