Some progress around root systems and Weyl groups #4271
+352
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieAlgebras
experimental
lgoettgens
force-pushed
the
lg/root-coeff-vector
branch
3 times, most recently
from
603600b
to
222af99
Compare
to show changes to printing in the following commits
lgoettgens
force-pushed
the
lg/root-coeff-vector
branch
from
222af99
to
489dc12
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4271 +/- ##
==========================================
- Coverage 84.49% 84.48% -0.02%
==========================================
Files 641 641
Lines 85473 85482 +9
==========================================
- Hits 72223 72221 -2
- Misses 13250 13261 +11
|
joschmitt
reviewed
Nov 5, 2024
Comment on lines
+64
to
+66
| julia> root_system([(:A, 2), (:F, 4)]) | ||
| Root system of rank 6 | ||
| of type A2 x F4 |
There was a problem hiding this comment.
I'm probably missing something, but would it make sense to just print the type (if it is known)?
Suggested change
| julia> root_system([(:A, 2), (:F, 4)]) | |
| Root system of rank 6 | |
| of type A2 x F4 | |
| julia> root_system([(:A, 2), (:F, 4)]) | |
| A2 x F4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
most important changes:
WeightLatticeElemis now a row (instead of a column); this is to be consistent withRootSpaceElem