Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports Oscar 1.0.1 #3574

Merged
merged 31 commits into from
Apr 17, 2024
Merged

Backports Oscar 1.0.1 #3574

merged 31 commits into from
Apr 17, 2024

Conversation

benlorenz
Copy link
Member

@benlorenz benlorenz commented Apr 9, 2024 •
edited
Loading

Still needs checking with book tests.

cherry-picked

with label

todo

not on master yet

antonydellavecchia and others added 9 commits April 9, 2024 16:49
@antonydellavecchia @benlorenz
Fix load polymake regression (#3481)
c08a23d 
* fixes loading polymake simplicial complex and other types

* adds test case

* removing unnecessary else

* fix test

(cherry picked from commit dcd3952)
@benlorenz
Serialization: fix save/load of Int matrices/vectors in polymake numb…
3af6207 
…erfield objects (#3508)

* Serialization: fix save/load of Int matrices/vectors in polymake numberfield objects

* Update test/Serialization/PolyhedralGeometry.jl

* fix for macos

(cherry picked from commit 5acd5c5)
@joschmitt @benlorenz
Provide links for some documentation references (#3503)
afefacd 
(cherry picked from commit 5ea63d1)
@antonydellavecchia @benlorenz
Fixes bug with loading vector of Fields (#3534)
fe11edc 
(cherry picked from commit 31228f5)
@thofma @benlorenz
fix: remove some (broken) leftover from surface serialization (#3545)
9ccec92 
(cherry picked from commit 8667f84)
@YueRen @benlorenz
TropicalGeometry: fixed typo in documentation (#3552)
1aaa185 
(cherry picked from commit 1ed5322)
@lgoettgens @benlorenz
Fix precompilation issue (#3565)
a1224cc 
(cherry picked from commit f16acc9)
@mjrodgers @benlorenz
Add is_conjugate* to docs/src/Groups/action.md
a9acdc1 
(cherry picked from commit 5765d5c)
@mjrodgers @benlorenz
oops used wrong signatures, fixed now
ad5d131 
(cherry picked from commit aead208)
@codecov Codecov
Copy link

codecov bot commented Apr 9, 2024 •
edited
Loading

Codecov Report

Merging #3574 (d1caf3f) into release-1.0 (a148cee) will increase coverage by 0.33%.
The diff coverage is 64.28%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.0    #3574      +/-   ##
===============================================
+ Coverage        82.10%   82.43%   +0.33%     
===============================================
  Files              563      563              
  Lines            75663    75727      +64     
===============================================
+ Hits             62120    62426     +306     
+ Misses           13543    13301     -242
Files Coverage Δ
src/AlgebraicGeometry/Surfaces/SurfacesP4.jl 16.66% <ø> (+1.85%) ⬆️
src/Modules/mpolyquo-localizations.jl 88.88% <100.00%> (ø)
src/Oscar.jl 70.14% <100.00%> (ø)
src/Rings/mpoly-affine-algebras.jl 80.27% <ø> (-0.06%) ⬇️
src/TropicalGeometry/variety.jl 63.42% <ø> (+33.79%) ⬆️
src/utils/tests.jl 60.95% <0.00%> (-0.59%) ⬇️
src/Serialization/containers.jl 95.35% <50.00%> (+0.89%) ⬆️
src/Serialization/polymake.jl 70.00% <71.42%> (-1.80%) ⬇️

... and 53 files with indirect coverage changes

@thofma thofma mentioned this pull request Apr 10, 2024
Closed
@fingolfin
Copy link
Member

Not sure if you'll scan for the "backport to 1.x" label again, but: PR #3579 is trivial and would be nice to have in, just in case somebody looks at the README :-)

@HereAround
Copy link
Member

HereAround commented Apr 10, 2024 •
edited
Loading

Similarly, it would be good to also have #3578 (@lkastner, please object if I am mistaken), since it fixes a failure in a book example that was caused by #3519.

@benlorenz
Copy link
Member Author

Not sure if you'll scan for the "backport to 1.x" label again, but: PR #3579 is trivial and would be nice to have in, just in case somebody looks at the README :-)

I will probably recheck the labels tomorrow morning and add #3579 to the branch.

Similarly, I would be good to also have #3578 (@lkastner, please object if I am mistaken), since it fixes a failure in a book example that was caused by #3519.

#3519 was not backported so #3578 is not needed on the release branch, the failure was only with master and not with the release branch.

fingolfin and others added 16 commits April 11, 2024 10:47
@fingolfin @benlorenz
README.md: fix OSCAR book title (#3579)
54cd2dd 
Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de>
(cherry picked from commit 8be19fa)
@joschmitt @benlorenz
Fix a vcat
89c074c 
(cherry picked from commit 837d22c)
@lgoettgens @benlorenz
Add paragraph about number_of_ to the styleguide. (#3305)
c7c6702 
(cherry picked from commit 5413e7a)
@joschmitt @benlorenz
Add information on how to cite OSCAR to doc (#3587)
ec3aa0b 
(cherry picked from commit 4424855)
@lkastner @benlorenz
Hide Oscar.jl banner, when used in other module (#3541)
fa04549 
Hide Oscar banner, when used in other module

(cherry picked from commit 6894701)
@lkastner @benlorenz
Test: Basic testing for book examples
f845fb2
@lkastner @benlorenz
fix jlcons, add aux code, fix whitespace
52dfd93
@benlorenz
booktests: allow skip, more aux code...
0fd4a18
@benlorenz
fix more whitespace, more aux code, cleanup
e6c1553
@benlorenz
refactor testing using mockdule
522057e 
keep repl per chapter
simplify rng usage
use broken and skipped lists
more regex
add to CI
add dependencies to test project
@benlorenz
adjust some whitespace + linebreak
ea70230
@benlorenz
booktest: put code inside testset block, allow running from test_module
12112cc
@benlorenz
booktest: remove su5-2 from broken
6df9a03
@benlorenz
booktests: move two currently broken tests to skipped to avoid sudden…
063445c 
… failures when these are fixed
@fingolfin @benlorenz
README.md: update citation info once more (#3600)
114ab12 
[skip ci]

(cherry picked from commit 68728ce)
@fingolfin @benlorenz
Fix links to people in Kaiserslautern (#3597)
0bb6d1a 
(cherry picked from commit c0bd7ba)
@benlorenz benlorenz marked this pull request as ready for review April 12, 2024 19:07
@joschmitt joschmitt linked an issue Apr 16, 2024 that may be closed by this pull request
Precompilation Error: Method definition number_of_generator in module AbstractAlgebra overwritten by Oscar #3576
Closed
@benlorenz benlorenz merged commit e0e8ed9 into release-1.0 Apr 17, 2024
28 checks passed
@benlorenz benlorenz deleted the backports-release-1.0 branch April 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@lkastner lkastner lkastner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Precompilation Error: Method definition number_of_generator in module AbstractAlgebra overwritten by Oscar
10 participants
@benlorenz @fingolfin @HereAround @lkastner @antonydellavecchia @joschmitt @thofma @YueRen @lgoettgens @mjrodgers