Fix Oscar.build()

[aaruni96]

Fixes Oscar.build() again, and adds generic CPU target as default.

[skip ci] as it doesn't change anything else which the tests might check for.

An important/questionable change I am making is to set peristent_tasks to false in Aqua.jl. When true, Oscar.build() fails for some reason I don't really understand. I am not sure what the consequences to not testing for that are.

@lgoettgens I think you added the Aqua tests. Do you know?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (cb54bfa) to head (f287739).
Report is 28 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3728      +/-   ##
==========================================
- Coverage   81.35%   81.25%   -0.11%     
==========================================
  Files         577      580       +3     
  Lines       78653    79159     +506     
==========================================
+ Hits        63991    64323     +332     
- Misses      14662    14836     +174     

see 47 files with indirect coverage changes

[thofma]

How long does that take to run typically? Maybe we can add a CI job to not break it again accidentally.

[lgoettgens]

Can you put the error log when enabling the Aqua test again here? Then I can have a look tomorrow

[lgoettgens]

Can you put the error log when enabling the Aqua test again here? Then I can have a look tomorrow

Of course you would need to remove the restriction to the short tests for this again, as the Aqua tests are part of the long tests.

[lgoettgens]

As I understand the running of tests in the pkgimage process is to exercise "common usecases" and compile them into the pkgimage. Nothing of the Aqua tests exercises any code from Oscar, so I think these tests should never be called from the pkgimage creation process.

[aaruni96]

How long does that take to run typically?

With just the short tests, it takes ~40 minutes on my workstation (~30 minutes for the tests, ~10 minutes for the system image building).

As far as I know this cannot be sped up via parallelisation, because all the code needs to execute on the process which will also eventually create the system image.

[thofma]

How long does that take to run typically?

With just the short tests, it takes ~40 minutes on my workstation (~30 minutes for the tests, ~10 minutes for the system image building).

As far as I know this cannot be sped up via parallelisation, because all the code needs to execute on the process which will also eventually create the system image.

Thanks for the numbers. I guess this makes a CI job an option for this, but this can be added later.