-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement change_base_ring
for hypercomplexes
#3794
Implement change_base_ring
for hypercomplexes
#3794
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3794 +/- ##
========================================
Coverage 84.65% 84.65%
========================================
Files 600 614 +14
Lines 82554 83324 +770
========================================
+ Hits 69885 70537 +652
- Misses 12669 12787 +118
|
change_base_ring
for hypercomplexes
Thanks. I will look it this later, after July 10. |
@micjoswig : Any new opinions on this? If yes, we might put this PR on the list for discussion for the upcoming Wednesday meeting. |
The relevant complexes don't exist in Oscar yet. My basic example would be the boundary complex of a finite simplicial complex. It is not very difficult. But we need to decide which part we take from polymake (or none at all). |
Thanks for the reply. To my understanding we can proceed with this PR in the meantime. How to bring over applications from Polymake is a different topic, I think. And we will need this functionality for other things, too. |
Janko is (organizing or doing a) review |
@HechtiDerLachs made some updates but tests are failing now. He'll work on it and together with @jankoboehm get this merged. |
tests are passing now, and here in triage @jankoboehm said he is fine with this being merged, so I'll just do that. |
@micjoswig : This is a prototype for what you asked for during the meeting. Have a look at the tests to see how to get started.
Currently there is little functionality supported for
ModuleFP
s over the integers. If you show me the type of complexes you're interested in, then I can work on making them available here.