Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Gröbner Walk #3821

Merged
merged 184 commits into from
Sep 5, 2024
Merged

Conversation

ooinaruhugh
Copy link
Contributor

@ooinaruhugh ooinaruhugh commented Jun 3, 2024

This PR supercedes #3131 and provides some variants of the Gröbner Walk.
Currently, this includes

  • Standard walk from Collart, Kalkbrener and Mall (1997)
  • Generic walk from Fukuda (2007)
  • Perturbed walk from Amrhein, Gloor and Küchlin (1997)

Further things we want to do:

  • feat: Groebner Walk #3131 included some more variants, we're still in the process of revising those.
  • Also, the code probably needs some tidying up.
  • We're currently investigating whether we can improve the performance of this implementation.
  • Tests

@fingolfin
Copy link
Member

We just discussed this during triage. @ederc is fine with the "big picture" (we can improve details later). @afkafkafk13 is as well happy with it, but would like to have another look before approving.

Since this is big and has been around, it indeed seems sensible to me to merged this rather sooner and fine tune it later, but I'll leave it to the experts to make the final call.

@fingolfin fingolfin removed the triage label Sep 4, 2024
@ooinaruhugh
Copy link
Contributor Author

Yeah, I agree with that. As far as I can tell, I addressed most of the previous remarks and the implemented algorithms do work correctly. I would also prefer to do any additions in a future PR.

@joschmitt joschmitt closed this Sep 5, 2024
@joschmitt joschmitt reopened this Sep 5, 2024
@joschmitt joschmitt enabled auto-merge (squash) September 5, 2024 07:30
@joschmitt joschmitt merged commit 34e1af7 into oscar-system:master Sep 5, 2024
53 of 54 checks passed
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
Co-authored-by: Ortfs <francesconowell@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants