-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: Gröbner Walk #3821
Conversation
We just discussed this during triage. @ederc is fine with the "big picture" (we can improve details later). @afkafkafk13 is as well happy with it, but would like to have another look before approving. Since this is big and has been around, it indeed seems sensible to me to merged this rather sooner and fine tune it later, but I'll leave it to the experts to make the final call. |
Yeah, I agree with that. As far as I can tell, I addressed most of the previous remarks and the implemented algorithms do work correctly. I would also prefer to do any additions in a future PR. |
Co-authored-by: Ortfs <francesconowell@gmail.com> Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
This PR supercedes #3131 and provides some variants of the Gröbner Walk.
Currently, this includes
Further things we want to do: