Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type changes for modules over non commutative rings #3988

Merged

Fix missing ring map.

046c51f
Select commit
Loading
Failed to load commit list.
Merged

Type changes for modules over non commutative rings #3988

Fix missing ring map.
046c51f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 13, 2024 in 0s

84.64% (-0.01%) compared to 97bc0a4, passed because coverage increased by -0.01% when compared to adjusted base (84.65%)

View this Pull Request on Codecov

84.64% (-0.01%) compared to 97bc0a4, passed because coverage increased by -0.01% when compared to adjusted base (84.65%)

Details

Codecov Report

Attention: Patch coverage is 68.88889% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (97bc0a4) to head (046c51f).

Files with missing lines Patch % Lines
src/Modules/UngradedModules/FreeModElem.jl 36.84% 12 Missing ⚠️
src/Modules/ModulesGraded.jl 90.00% 1 Missing ⚠️
src/Modules/UngradedModules/SubQuoHom.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3988      +/-   ##
==========================================
- Coverage   84.65%   84.64%   -0.01%     
==========================================
  Files         614      614              
  Lines       83344    83349       +5     
==========================================
- Hits        70554    70550       -4     
- Misses      12790    12799       +9     
Files with missing lines Coverage Δ
...try/Schemes/ProjectiveSchemes/Morphisms/Methods.jl 61.53% <100.00%> (ø)
src/Modules/ModuleTypes.jl 78.90% <100.00%> (ø)
src/Modules/UngradedModules/FreeMod.jl 84.31% <100.00%> (ø)
src/Modules/UngradedModules/SubquoModule.jl 75.53% <100.00%> (ø)
src/Modules/UngradedModules/SubquoModuleElem.jl 84.21% <100.00%> (ø)
src/Modules/ModulesGraded.jl 73.72% <90.00%> (ø)
src/Modules/UngradedModules/SubQuoHom.jl 77.60% <75.00%> (ø)
src/Modules/UngradedModules/FreeModElem.jl 85.71% <36.84%> (-10.29%) ⬇️

... and 1 file with indirect coverage changes