Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to FreeAssAlgIdeal #4035

Merged
merged 20 commits into from
Sep 5, 2024
Merged

Updates to FreeAssAlgIdeal #4035

merged 20 commits into from
Sep 5, 2024

Conversation

Sequenzer
Copy link
Collaborator

@Sequenzer Sequenzer commented Aug 21, 2024 •
edited
Loading

  • Added deg_bound field to FreeAssAlgIdeal struct for speed improvement
  • Modified constructor to initialize deg_bound and gb.
  • Implemented Base.show for FreeAssAlgIdeal.
  • Added equality and membership functions for FreeAssAlgIdeal.
  • Updated ideal function.
  • Enhanced groebner_basis functions with interreduce option.
  • Added is_groebner_basis and interreduce! functions.
  • Added some more test for integrated testing with quantum_automorphism_groups.
  • Renamed FreeAssAlg -> FreeAssociativeAlgebra

@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.70199% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (a854435) to head (80387d3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Rings/FreeAssociativeAlgebraIdeal.jl 92.66% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4035      +/-   ##
==========================================
- Coverage   84.66%   84.65%   -0.02%     
==========================================
  Files         600      601       +1     
  Lines       82622    82676      +54     
==========================================
+ Hits        69956    69989      +33     
- Misses      12666    12687      +21
Files with missing lines Coverage Δ
src/Groups/action.jl 97.16% <100.00%> (ø)
src/Serialization/Algebras.jl 100.00% <100.00%> (ø)
src/Serialization/Rings.jl 97.78% <ø> (ø)
src/Serialization/Upgrades/0.15.0.jl 100.00% <100.00%> (+8.33%) ⬆️
src/Serialization/Upgrades/1.2.0.jl 100.00% <100.00%> (ø)
src/Serialization/Upgrades/main.jl 100.00% <100.00%> (ø)
src/deprecations.jl 0.00% <ø> (ø)
src/imports.jl 0.00% <ø> (ø)
src/Rings/FreeAssociativeAlgebraIdeal.jl 92.66% <92.66%> (ø)

... and 1 file with indirect coverage changes

@Sequenzer Sequenzer marked this pull request as draft August 21, 2024 12:05
@Sequenzer Sequenzer marked this pull request as ready for review August 21, 2024 12:15
lgoettgens
lgoettgens reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some misc comments of things that confused me

src/Rings/FreeAssAlgIdeal.jl Outdated Show resolved Hide resolved
src/Rings/FreeAssAlgIdeal.jl Outdated Show resolved Hide resolved
src/Rings/FreeAssAlgIdeal.jl Outdated Show resolved Hide resolved
src/Rings/FreeAssAlgIdeal.jl Outdated Show resolved Hide resolved
src/Rings/FreeAssAlgIdeal.jl Outdated Show resolved Hide resolved
@lgoettgens lgoettgens mentioned this pull request Aug 28, 2024
Closed
@Sequenzer
FreeAssAlgIdeal -> FreeAssociativeAlgebraIdeal
5532ef1
@Sequenzer
update AbstractAlgebra and rename FreeAssAlgebra
b02dec0 
- Updated AbstractAlgebra version from 0.42.0 to 0.42.3 in Project.toml
- `FreeAssAlgebra` -> `FreeAssociativeAlgebra`
@Sequenzer
FreeAssAlgElem -> FreeAssociativeAlgebraElem
f95b0b2
@joschmitt joschmitt linked an issue Aug 29, 2024 that may be closed by this pull request
Streamline FreeAssAlgebra and Hecke.AssociativeAlgebraElem #4043
Closed
@lgoettgens
Copy link
Member

@antonydellavecchia It seems that 8990f92 (#4035) broke CI

@fingolfin fingolfin self-requested a review September 4, 2024 09:52
@fingolfin
Copy link
Member

I'll take a look at this PR this afternoon, and either merge it or request changes. If I haven't done it by the end of the day, feel free to just merge, I can always get changes in later as well.

@fingolfin fingolfin removed the triage label Sep 4, 2024
lgoettgens
lgoettgens approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been addressed. And Max didn't do a review yesterday, so let's merge this for now.

@lgoettgens lgoettgens enabled auto-merge (squash) September 5, 2024 08:07
@lgoettgens lgoettgens merged commit 81f64bd into oscar-system:master Sep 5, 2024
28 checks passed
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
@Sequenzer @antonydellavecchia
@lgoettgens @HechtiDerLachs
Updates to FreeAssAlgIdeal (oscar-system#4035)
d16083f 
Co-authored-by: Antony Della Vecchia <vecchia@math.tu-berlin.de>
Co-authored-by: antonydellavecchia <antonydellavecchia@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonydellavecchia antonydellavecchia antonydellavecchia left review comments

@joschmitt joschmitt joschmitt left review comments

@lgoettgens lgoettgens lgoettgens approved these changes

@fingolfin fingolfin Awaiting requested review from fingolfin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamline FreeAssAlgebra and Hecke.AssociativeAlgebraElem
5 participants
@Sequenzer @lgoettgens @fingolfin @antonydellavecchia @joschmitt