Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to FreeAssAlgIdeal #4035

Merged
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9e88254
some changes
Sequenzer Aug 14, 2024
c41b886
Merge branch 'oscar-system:master' into feature/ncgroebner-termorder
Sequenzer Aug 21, 2024
0e42541
added ordering support, as well as minor changes, plus some tests
Sequenzer Aug 21, 2024
217c9d2
in to is_subset
Sequenzer Aug 21, 2024
fd814e7
fixed the slowdown caused by is_groebner_basis (The function is still…
Sequenzer Aug 21, 2024
aa4d7c7
improving codecov
Sequenzer Aug 21, 2024
5fa7b08
even more tests for coverage
Sequenzer Aug 22, 2024
ed1643f
added Lars suggestion for hash function
Sequenzer Aug 27, 2024
5532ef1
`FreeAssAlgIdeal` -> `FreeAssociativeAlgebraIdeal`
Sequenzer Aug 29, 2024
b02dec0
update AbstractAlgebra and rename FreeAssAlgebra
Sequenzer Aug 29, 2024
f95b0b2
`FreeAssAlgElem` -> `FreeAssociativeAlgebraElem`
Sequenzer Aug 29, 2024
1f14480
upgrade script
Sequenzer Aug 29, 2024
87b9206
fix of kwarg change in FreeAssAlgebraIdeal
Sequenzer Aug 29, 2024
52bd763
removed the check_groebner_basis functionality
Sequenzer Aug 29, 2024
af5a479
switched out assert, added a base_ring check to is_subset
Sequenzer Aug 29, 2024
8990f92
refactored upgrade types + fix upgrade script for dicts + test
antonydellavecchia Aug 29, 2024
2709e35
fix tests
antonydellavecchia Aug 30, 2024
473d8f1
fixes backwards compatibility test
antonydellavecchia Sep 2, 2024
3255695
Merge branch 'master' into feature/ncgroebner-termorder
lgoettgens Sep 4, 2024
80387d3
Merge branch 'master' into feature/ncgroebner-termorder
lgoettgens Sep 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
cohomCalg_jll = "5558cf25-a90e-53b0-b813-cadaa3ae7ade"

[compat]
AbstractAlgebra = "0.42.0"
AbstractAlgebra = "0.42.3"
AlgebraicSolving = "0.5.1"
Distributed = "1.6"
GAP = "0.10.2"
Expand Down
10 changes: 5 additions & 5 deletions docs/src/NoncommutativeAlgebra/free_associative_algebra.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ CurrentModule = Oscar
### Types

The OSCAR type for two-sided ideals in a free associative algebra is
`FreeAssAlgIdeal{T}`, where `T` is the element type of the algebra.
`FreeAssociativeAlgebraIdeal{T}`, where `T` is the element type of the algebra.

### Constructors

```julia
ideal(R::FreeAssAlgebra, g::Vector{T}) where T <: FreeAssAlgElem
ideal(g::Vector{T}) where T <: FreeAssAlgElem
ideal(R::FreeAssociativeAlgebra, g::Vector{T}) where T <: FreeAssociativeAlgebraElem
ideal(g::Vector{T}) where T <: FreeAssociativeAlgebraElem
```

### Ideal Membership
Expand All @@ -25,11 +25,11 @@ Non-commutative polynomial rings are not Noetherian. Hence, in general, Groebne
Setting the parameter `deg_bound` to a positive value yields the truncation of the Groebner bases to a fixed degree. Such a truncation is always finite.

```@docs
groebner_basis(I::FreeAssAlgIdeal, deg_bound::Int=-1; protocol::Bool=false)
groebner_basis(I::FreeAssociativeAlgebraIdeal, deg_bound::Int=-1; protocol::Bool=false)
```

If a finite Gröbner basis exists, it solves the ideal membership problem.

```@docs
ideal_membership(a::FreeAssAlgElem, I::FreeAssAlgIdeal, deg_bound::Int)
ideal_membership(a::FreeAssociativeAlgebraElem, I::FreeAssociativeAlgebraIdeal, deg_bound::Int)
```
8 changes: 4 additions & 4 deletions src/Groups/action.jl
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,12 @@ end
@doc raw"""
on_indeterminates(f::GapObj, p::PermGroupElem)
on_indeterminates(f::MPolyRingElem, p::PermGroupElem)
on_indeterminates(f::FreeAssAlgElem, p::PermGroupElem)
on_indeterminates(f::FreeAssociativeAlgebraElem, p::PermGroupElem)
on_indeterminates(f::MPolyIdeal, p::PermGroupElem)

Return the image of `f` under `p` where `p` acts via permuting the indeterminates.

For `MPolyRingElem`, `FreeAssAlgElem`, and `MPolyIdeal` objects,
For `MPolyRingElem`, `FreeAssociativeAlgebraElem`, and `MPolyIdeal` objects,
one can also call `^` instead of `on_indeterminates`.

# Examples
Expand Down Expand Up @@ -303,7 +303,7 @@ function on_indeterminates(f::MPolyRingElem, s::PermGroupElem)
return finish(g)
end

function on_indeterminates(f::FreeAssAlgElem{T}, s::PermGroupElem) where T
function on_indeterminates(f::FreeAssociativeAlgebraElem{T}, s::PermGroupElem) where T
G = parent(s)
S = parent(f)
@assert ngens(S) == degree(G)
Expand Down Expand Up @@ -374,7 +374,7 @@ end

^(f::MPolyRingElem, p::PermGroupElem) = on_indeterminates(f, p)

^(f::FreeAssAlgElem, p::PermGroupElem) = on_indeterminates(f, p)
^(f::FreeAssociativeAlgebraElem, p::PermGroupElem) = on_indeterminates(f, p)

^(f::MPolyRingElem{T}, p::MatrixGroupElem{T, S}) where T where S = on_indeterminates(f, p)

Expand Down
192 changes: 0 additions & 192 deletions src/Rings/FreeAssAlgIdeal.jl

This file was deleted.

Loading
Loading