Adv/multi file serialization #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4067 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 614 614
Lines 83331 83344 +13
=======================================
+ Hits 70542 70554 +12
- Misses 12789 12790 +1
|
lgoettgens
reviewed
Sep 6, 2024
…to adv/multi-file-serialization
benlorenz
approved these changes
Sep 12, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 13, 2024
* updates for serializers * working proof of concept * test multi file * small fix for loading without attrs * fixing merge * Update src/Groups/GAPGroups.jl * fixes errors introduced from merge * simplify saving external lp * fixes from discussion * Update src/Serialization/PolyhedralGeometry.jl * forgot to change type in signature * typo * fix for LP tests * missed input type for one of the saves * pass kw to load in setup tests * fixes warning + polyhedral sets * version number check without commit * hack to now check dev version * hack to not check dev version * deal with conflicts --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for multi file serialization.
Comments and suggestions welcome.