change variable labeling for default grassmann pluecker ideal (Related to issue #4018) #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
approved these changes
Sep 4, 2024
|
It appears I branched off of an old master creating merge conflicts. Will address this later |
|
I did my best to try to resolve the conflict of this with #3765. @danteluber please check if this is what you intended |
lgoettgens
reviewed
Sep 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4074 +/- ##
==========================================
- Coverage 84.66% 84.63% -0.03%
==========================================
Files 600 600
Lines 82627 82629 +2
==========================================
- Hits 69956 69933 -23
- Misses 12671 12696 +25
|
antonydellavecchia
approved these changes
Sep 6, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 13, 2024
…d to issue oscar-system#4018) (oscar-system#4074) * change variable labeling for default grassmann pluecker ideal * Update src/Rings/mpoly-ideals.jl --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de> Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing default variable labeling for Grassmann Pluecker ideal. Variables are now indexed by sets. Related to issue #4018.