Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix groups: cleanup some use of frobenius #4079

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

fingolfin
Copy link
Member

Also added a comment on how conjugate_transpose could be
made more efficient if needed

Also added a comment on how conjugate_transpose could be
made more efficient if needed
Copy link
Collaborator

@mjrodgers mjrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, I can talk to @fieker about updating to precompute the Frobenius map if this is an improvement we should make but in the meantime I think this should be merged (modulo the tests passing, looking at those now).

@mjrodgers
Copy link
Collaborator

Have another error I'm trying to straighten out still, getting a BoundsError from conjugate_transpose with this one:

F,a = finite_field(3,2,"a")
x = diagonal_matrix(F.([1,2,1,1,1]))
y = diagonal_matrix(F.([2,1,0,0,2]))
y[3,4]=a; y[4,3]=a^3; y[4,5]=1+a; y[5,4]=(1+a)^3;
f = hermitian_form(x); g = hermitian_form(y)
is_true,z = is_congruent(f,g)

@mjrodgers
Copy link
Collaborator

Have another error I'm trying to straighten out

OK I think this is resolved too, if the rest of the tests pass I think this can be merged now.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (224cb53) to head (790e02c).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4079   +/-   ##
=======================================
  Coverage   84.64%   84.65%           
=======================================
  Files         612      614    +2     
  Lines       83240    83332   +92     
=======================================
+ Hits        70460    70543   +83     
- Misses      12780    12789    +9     
Files with missing lines Coverage Δ
src/Groups/matrices/matrix_manipulation.jl 97.40% <100.00%> (+0.10%) ⬆️
src/Groups/matrices/transform_form.jl 98.51% <100.00%> (+0.02%) ⬆️

... and 14 files with indirect coverage changes

@joschmitt joschmitt merged commit dbc2a03 into oscar-system:master Sep 12, 2024
28 checks passed
@fingolfin fingolfin deleted the mh/frobenius branch September 12, 2024 07:46
@fingolfin
Copy link
Member Author

Thank you all for brining my shoddy PR over the finishing line :-)

HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
* Matrix groups: cleanup some use of frobenius

Also added a comment on how conjugate_transpose could be
made more efficient if needed

* Fix precompile error (courtesy of @thofma)

* fix `_type` -> `Val(_type)`

* fix `frobenius` application

* add return statement

* fix `conjugate_transpose` indices

---------

Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de>
Co-authored-by: Morgan Rodgers <morgan.joaquin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants