-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix groups: cleanup some use of frobenius #4079
Conversation
Also added a comment on how conjugate_transpose could be made more efficient if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, I can talk to @fieker about updating to precompute the Frobenius map if this is an improvement we should make but in the meantime I think this should be merged (modulo the tests passing, looking at those now).
Have another error I'm trying to straighten out still, getting a F,a = finite_field(3,2,"a")
x = diagonal_matrix(F.([1,2,1,1,1]))
y = diagonal_matrix(F.([2,1,0,0,2]))
y[3,4]=a; y[4,3]=a^3; y[4,5]=1+a; y[5,4]=(1+a)^3;
f = hermitian_form(x); g = hermitian_form(y)
is_true,z = is_congruent(f,g) |
OK I think this is resolved too, if the rest of the tests pass I think this can be merged now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
=======================================
Coverage 84.64% 84.65%
=======================================
Files 612 614 +2
Lines 83240 83332 +92
=======================================
+ Hits 70460 70543 +83
- Misses 12780 12789 +9
|
Thank you all for brining my shoddy PR over the finishing line :-) |
* Matrix groups: cleanup some use of frobenius Also added a comment on how conjugate_transpose could be made more efficient if needed * Fix precompile error (courtesy of @thofma) * fix `_type` -> `Val(_type)` * fix `frobenius` application * add return statement * fix `conjugate_transpose` indices --------- Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de> Co-authored-by: Morgan Rodgers <morgan.joaquin@gmail.com>
Also added a comment on how conjugate_transpose could be
made more efficient if needed