fix GAP.julia_to_gap(T::SubgroupTransversal)
#4081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been cherry-picked into #3688. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4081 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 614 614
Lines 83325 83325
=======================================
+ Hits 70536 70538 +2
+ Misses 12789 12787 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem arose from the improvement in oscar-system/GAP.jl#989:
Right transversal objects are
AbstractVectors, and now a three argument method for these objects is available in GAP.jl, which is not the method one wants.The fix is preliminary, things will become better again as soon as
julia_to_gapgets reworked, see oscar-system/GAP.jl#1025.