Disable caching in a restriction_map method #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
commented
Sep 16, 2024
| @@ -243,7 +243,7 @@ function restriction_map( | |||
| # the terms accordingly, we derive the desired expressions for the cᵢ's. | |||
| #W = localized_ring(OO(Y)) | |||
| W = OO(Y) | |||
| S, t = polynomial_ring(W, ["t$i" for i in 1:r]) | |||
| S, t = polynomial_ring(W, ["t$i" for i in 1:r]; cached=false) | |||
There was a problem hiding this comment.
This is the only important change in this PR. The rest is just rewriting to make things more terse but otherwise has no semantic effect whatsoever and could also be dropped from this PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4091 +/- ##
=======================================
Coverage 84.64% 84.64%
=======================================
Files 614 614
Lines 83343 83343
=======================================
Hits 70548 70548
Misses 12795 12795
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3865. On the surface it looks to me as if this one is harmless. We'll see whether the tests pass.