Disable polynomial ring caching in projective_space and affine_space methods
#4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
requested review from
simonbrandhorst,
afkafkafk13 and
HechtiDerLachs
simonbrandhorst
approved these changes
Sep 16, 2024
fingolfin
force-pushed
the
mh/no-caching-in-ag-constructors
branch
from
6974109
to
833e4be
Compare
fingolfin
commented
Sep 16, 2024
| # ring around the rosie once | ||
| @test pX == X(rational_point_coordinates(defining_ideal(scheme(pX)))) | ||
| Oscar.closed_embedding(pA) | ||
| Oscar.closed_embedding(pX) | ||
| @test dim(tangent_space(pX))==1 | ||
| @test dim(tangent_space(pA))==2 | ||
|
|
||
| A2a = affine_space(GF(2), [:x, :y]); | ||
| @test A2a([1,0]) == pA |
There was a problem hiding this comment.
This test failed because now A2 and A2a are not using the same polynomial ring anymore (note that A2 != A2a holds now and also before)
lgoettgens
changed the title
projective_space and affine_space methods
lgoettgens
changed the title
projective_space and affine_space methods
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4094 +/- ##
==========================================
- Coverage 84.63% 84.63% -0.01%
==========================================
Files 614 614
Lines 83366 83366
==========================================
- Hits 70558 70556 -2
- Misses 12808 12810 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of PR #3865 (and this part of it was already discussed extensively there)
I hope it'll either just pass fine, or if it has problems, then at least just a subset of those in PR #3865.