document and clean up algebraic cycles #4137

simonbrandhorst · 2024-09-23T16:09:29Z

No description provided.

simonbrandhorst · 2024-09-23T16:10:40Z

HechtiDerLachs

Looks good. Thank you for cleaning this up!

For now the mathematical description of the functions is spelled out in the documentation. We should, however, go through the literature and eventually adjust the notions and/or give references on the next appropriate occasion.

src/AlgebraicGeometry/Schemes/Divisors/Types.jl

HechtiDerLachs · 2024-09-24T07:24:45Z

I "fixed" the tests by coherently passing on the check argument so that the failure will hopefully not be triggered anymore. However, the problem remains for now, so I opened the issue #4138 .

simonbrandhorst · 2024-09-24T07:47:37Z

Thank you.

simonbrandhorst · 2024-09-24T07:50:52Z

src/AlgebraicGeometry/Schemes/Divisors/CartierDivisor.jl

-      temp_dict=IdDict{AbsAffineScheme,Ideal}()
-      temp_dict[U] = comp
-      I_sheaf_temp = IdealSheaf(X, extend!(cov, temp_dict), check=false)
+      I_sheaf_temp = PrimeIdealSheafFromChart(X, U, comp, check=false)


This is a non-trivial change.

I have some doubts about this function irreducible_decomposition(::EffectiveCartierDivisor).
It seems to assume that this Cartier divisor is a Weyl divisor. Do we need to assume the ambient scheme $X$ to be regular in codimension one for this to work? And if it is not, what is computed here?

Also I wonder if we could return a Weyl divisor here.

This is a non-trivial change.

This function was written long before we had PrimeIdealSheafFromChart. The change makes sense.

Also I wonder if we could return a Weyl divisor here.
Would make sense.

benlorenz

There are several calls to the now deprecated in_linear_system in /test/AlgebraicGeometry/Schemes/WeilDivisor.jl which now need the extra is_:

Oscar.jl/test/AlgebraicGeometry/Schemes/WeilDivisor.jl

Lines 126 to 130 in c35f32a

    
           @test in_linear_system(KK(x[1]), D) 
        
           @test !in_linear_system(KK(x[1]^2), D) 
        
           @test in_linear_system(KK(x[1]^2), 2*D) 
        
           # Not running at the moment; work in progress 
        
           #@test !in_linear_system(KK(x[1], x[2]), D)

(and further down as well)

HechtiDerLachs · 2024-09-24T12:24:44Z

@simonbrandhorst : Looks like we messed up our book tests again. Do you have an idea why?

…s, move some stuff

afkafkafk13

I leave you a few nitpicks -- mostly on the docstrings.

src/AlgebraicGeometry/Schemes/Divisors/AlgebraicCycles.jl

afkafkafk13 · 2024-09-24T19:41:41Z

src/AlgebraicGeometry/Schemes/Divisors/CartierDivisor.jl

-      temp_dict=IdDict{AbsAffineScheme,Ideal}()
-      temp_dict[U] = comp
-      I_sheaf_temp = IdealSheaf(X, extend!(cov, temp_dict), check=false)
+      I_sheaf_temp = PrimeIdealSheafFromChart(X, U, comp, check=false)


This is a non-trivial change.

This function was written long before we had PrimeIdealSheafFromChart. The change makes sense.

afkafkafk13 · 2024-09-24T19:42:13Z

src/AlgebraicGeometry/Schemes/Divisors/CartierDivisor.jl

-      temp_dict=IdDict{AbsAffineScheme,Ideal}()
-      temp_dict[U] = comp
-      I_sheaf_temp = IdealSheaf(X, extend!(cov, temp_dict), check=false)
+      I_sheaf_temp = PrimeIdealSheafFromChart(X, U, comp, check=false)


Also I wonder if we could return a Weyl divisor here.
Would make sense.

src/AlgebraicGeometry/Schemes/Divisors/Types.jl

src/AlgebraicGeometry/Schemes/Divisors/WeilDivisor.jl

src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl

test/AlgebraicGeometry/Schemes/elliptic_surface_disabled.jl

codecov · 2024-09-25T16:32:00Z

Codecov Report

Attention: Patch coverage is 76.00000% with 84 lines in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (9fdbd24) to head (c97dbd9).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
.../AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl	69.34%	42 Missing ⚠️
...gebraicGeometry/Schemes/Divisors/CartierDivisor.jl	67.44%	14 Missing ⚠️
experimental/Schemes/src/Types.jl	84.37%	10 Missing ⚠️
...ebraicGeometry/Schemes/Divisors/AlgebraicCycles.jl	78.94%	8 Missing ⚠️
...Geometry/Schemes/CoveredSchemes/Morphisms/Types.jl	55.55%	4 Missing ⚠️
.../AlgebraicGeometry/Schemes/Divisors/WeilDivisor.jl	92.00%	2 Missing ⚠️
experimental/Schemes/src/elliptic_surface.jl	50.00%	1 Missing ⚠️
src/AlgebraicGeometry/Schemes/Divisors/Types.jl	87.50%	1 Missing ⚠️
.../Schemes/ProjectiveVariety/Objects/Constructors.jl	50.00%	1 Missing ⚠️
...gebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
+ Coverage   84.66%   84.69%   +0.03%     
==========================================
  Files         626      627       +1     
  Lines       84316    84301      -15     
==========================================
+ Hits        71382    71400      +18     
+ Misses      12934    12901      -33

Files with missing lines	Coverage Δ
experimental/Schemes/src/Auxiliary.jl	`94.20% <100.00%> (ø)`
experimental/Schemes/src/BlowupMorphism.jl	`89.73% <100.00%> (+0.10%)`	⬆️
...perimental/Schemes/src/CoveredProjectiveSchemes.jl	`89.18% <ø> (+0.88%)`	⬆️
experimental/Schemes/src/Resolution_structure.jl	`67.31% <100.00%> (-0.23%)`	⬇️
...eometry/Schemes/ProjectiveVariety/Objects/Types.jl	`100.00% <100.00%> (+21.05%)`	⬆️
src/deprecations.jl	`0.00% <ø> (ø)`
src/forward_declarations.jl	`100.00% <ø> (ø)`
experimental/Schemes/src/elliptic_surface.jl	`91.11% <50.00%> (ø)`
src/AlgebraicGeometry/Schemes/Divisors/Types.jl	`91.66% <87.50%> (-1.44%)`	⬇️
.../Schemes/ProjectiveVariety/Objects/Constructors.jl	`75.00% <50.00%> (-3.27%)`	⬇️
... and 7 more

thofma · 2024-09-25T19:13:02Z

I am curious about the change from in_bla to is_in_bla. Since we have in and in_radical, the name in_linear_system sounds "natural" to me.

simonbrandhorst · 2024-09-26T07:15:51Z

This was my doing. My thought was that the function returns a boolean and therefore should be called is_something ... But on second thought this rule seems to apply mostly to properties, i.e. single argument methods.
Maybe the change was premature.
In any case we want in(::VarietyFunctionField, ::LinearSystem) at some point.

simonbrandhorst · 2024-09-26T07:17:35Z

julia> inradical
inradical (generic function with 1 method)

julia> in_radical
ERROR: UndefVarError: `in_radical` not defined

thofma · 2024-09-26T07:18:55Z

src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl

@@ -2140,3 +2240,88 @@ is_one(II::SingularLocusIdealSheaf) = all(is_one(produce_non_radical_ideal_of_si

 in_radical(J::AbsIdealSheaf, II::SingularLocusIdealSheaf) = all(all(radical_membership(g, produce_non_radical_ideal_of_singular_locus(II, U)) for g in gens(J(U))) for U in affine_charts(scheme(J)))


@simonbrandhorst this one here

* document algebraic cycles * move some type declatations in Schemes/ to Schemes/Types.jl --------- Co-authored-by: HechtiDerLachs <zach@mathematik.uni-kl.de> Co-authored-by: afkafkafk13 <anne.fruehbis-krueger@uol.de>

document algebraic cycles

49343cb

HechtiDerLachs approved these changes Sep 23, 2024

View reviewed changes

src/AlgebraicGeometry/Schemes/Divisors/Types.jl Outdated Show resolved Hide resolved

HechtiDerLachs added 2 commits September 23, 2024 18:39

Fix some tests and replace if check by @check.

e4def6a

Pass on internal check argument.

c35f32a

HechtiDerLachs mentioned this pull request Sep 24, 2024

Equidimensional decomposition fails over extensions of IF_p #4138

Closed

simonbrandhorst commented Sep 24, 2024

View reviewed changes

benlorenz reviewed Sep 24, 2024

View reviewed changes

fix iszero for cartier divisors, scheme to ambient_scheme for divisor…

9754647

…s, move some stuff

simonbrandhorst changed the title ~~document algebraic cycles~~ document and clean up algebraic cycles Sep 24, 2024

afkafkafk13 reviewed Sep 24, 2024

View reviewed changes

simonbrandhorst added 2 commits September 25, 2024 10:40

more documentation,test,exports

24320d9

cleanup

4af32e1

afkafkafk13 approved these changes Sep 25, 2024

View reviewed changes

benlorenz reviewed Sep 25, 2024

View reviewed changes

test/AlgebraicGeometry/Schemes/elliptic_surface_disabled.jl Outdated Show resolved Hide resolved

benlorenz reviewed Sep 25, 2024

View reviewed changes

test/AlgebraicGeometry/Schemes/elliptic_surface_disabled.jl Outdated Show resolved Hide resolved

simonbrandhorst added 11 commits September 25, 2024 11:33

remove stale file

5c25052

fix typo

20ccc20

more ambient_scheme

1a219b1

fix a doctest

a0ed684

Merge branch 'master' into sb/divisor_docu

afd85a6

another ambient_scheme

cf4912e

diable a doctest because of unstable printing

2426e7b

more ambient_scheme

5fb3192

fix

0cb1614

move stuff around

2d07759

move some type declatations in Schemes/ to Schemes/Types.jl

c97dbd9

simonbrandhorst enabled auto-merge (squash) September 25, 2024 15:23

simonbrandhorst disabled auto-merge September 25, 2024 15:23

simonbrandhorst enabled auto-merge (squash) September 25, 2024 15:24

afkafkafk13 approved these changes Sep 25, 2024

View reviewed changes

simonbrandhorst merged commit c806a9d into master Sep 25, 2024
27 of 29 checks passed

simonbrandhorst deleted the sb/divisor_docu branch September 25, 2024 16:52

thofma reviewed Sep 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

document and clean up algebraic cycles #4137

document and clean up algebraic cycles #4137

simonbrandhorst commented Sep 23, 2024

simonbrandhorst commented Sep 23, 2024

HechtiDerLachs left a comment

HechtiDerLachs commented Sep 24, 2024

simonbrandhorst commented Sep 24, 2024

simonbrandhorst Sep 24, 2024

simonbrandhorst Sep 24, 2024

afkafkafk13 Sep 24, 2024

afkafkafk13 Sep 24, 2024

benlorenz left a comment

HechtiDerLachs commented Sep 24, 2024

afkafkafk13 left a comment

afkafkafk13 Sep 24, 2024

afkafkafk13 Sep 24, 2024

codecov bot commented Sep 25, 2024 •

edited

Loading

thofma commented Sep 25, 2024

simonbrandhorst commented Sep 26, 2024

simonbrandhorst commented Sep 26, 2024

thofma Sep 26, 2024

	@test in_linear_system(KK(x[1]), D)
	@test !in_linear_system(KK(x[1]^2), D)
	@test in_linear_system(KK(x[1]^2), 2*D)
	# Not running at the moment; work in progress
	#@test !in_linear_system(KK(x[1], x[2]), D)

		@@ -2140,3 +2240,88 @@ is_one(II::SingularLocusIdealSheaf) = all(is_one(produce_non_radical_ideal_of_si

		in_radical(J::AbsIdealSheaf, II::SingularLocusIdealSheaf) = all(all(radical_membership(g, produce_non_radical_ideal_of_singular_locus(II, U)) for g in gens(J(U))) for U in affine_charts(scheme(J)))

document and clean up algebraic cycles #4137

document and clean up algebraic cycles #4137

Conversation

simonbrandhorst commented Sep 23, 2024

simonbrandhorst commented Sep 23, 2024

HechtiDerLachs left a comment

Choose a reason for hiding this comment

HechtiDerLachs commented Sep 24, 2024

simonbrandhorst commented Sep 24, 2024

simonbrandhorst Sep 24, 2024

Choose a reason for hiding this comment

simonbrandhorst Sep 24, 2024

Choose a reason for hiding this comment

afkafkafk13 Sep 24, 2024

Choose a reason for hiding this comment

afkafkafk13 Sep 24, 2024

Choose a reason for hiding this comment

benlorenz left a comment

Choose a reason for hiding this comment

HechtiDerLachs commented Sep 24, 2024

afkafkafk13 left a comment

Choose a reason for hiding this comment

afkafkafk13 Sep 24, 2024

Choose a reason for hiding this comment

afkafkafk13 Sep 24, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 25, 2024 • edited Loading

Codecov Report

thofma commented Sep 25, 2024

simonbrandhorst commented Sep 26, 2024

simonbrandhorst commented Sep 26, 2024

thofma Sep 26, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 25, 2024 •

edited

Loading