Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "load the GAP packages sotgrps and sglppow" #4141

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

fingolfin
Copy link
Member

This reverts PR #3517 / commit 55ea957.

We can reland it as soon as the underlying issue is fixed, but for now this brings relieve to people who are affected by issue #4136.

Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling just sglppow would suffice to avoid the error.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (6238fc7) to head (b07d4c4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4141   +/-   ##
=======================================
  Coverage   84.65%   84.66%           
=======================================
  Files         626      626           
  Lines       84316    84316           
=======================================
+ Hits        71380    71382    +2     
+ Misses      12936    12934    -2     
Files with missing lines Coverage Δ
src/Oscar.jl 68.75% <ø> (ø)

... and 1 file with indirect coverage changes

@fingolfin fingolfin merged commit 38ebafb into oscar-system:master Sep 24, 2024
28 checks passed
@fingolfin fingolfin deleted the mh/revert branch September 24, 2024 23:55
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants