Attempt to clear up mpolyquo modules #4147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HechtiDerLachs : What is the status here (relative to the fact that #4134 has been merged in the meantime)? |
|
This would need to be cleaned up. But I will do it another time. I was hoping that this helps with a specific computation, but it didnt. So priority has become lower again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #4134 we should consider replacing the magic three functions for modules over
MPolyQuoRings. I hope to speed up some computations with this which we need together with @simon-felten.This is just a first try to get an idea about whether the tests fail. For
coordinateswe should look into the caching, etc. All this I would prefer to discuss in person on the next occasion.