Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename blowdown to blowup #4148

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Rename blowdown to blowup #4148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52da892
Rename blowdown to blowup
paemurru Sep 24, 2024
4ad9d7e
One more rename
paemurru Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/doc.main
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
"AlgebraicGeometry/ToricVarieties/ToricMorphisms.md",
"AlgebraicGeometry/ToricVarieties/ToricSchemes.md",
"AlgebraicGeometry/ToricVarieties/ToricIdealSheaves.md",
"AlgebraicGeometry/ToricVarieties/BlowdownMorphisms.md",
"AlgebraicGeometry/ToricVarieties/BlowupMorphisms.md",
],
"Miscellaneous" => [
"AlgebraicGeometry/Miscellaneous/miscellaneous.md",
Expand Down
22 changes: 11 additions & 11 deletions ...metry/ToricVarieties/BlowdownMorphisms.md → ...eometry/ToricVarieties/BlowupMorphisms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,23 @@ blow_up(m::NormalToricVariety, I::ToricIdealSheafFromCoxRingIdeal; coordinate_na
## Attributes

```@docs
underlying_morphism(bl::ToricBlowdownMorphism)
index_of_new_ray(bl::ToricBlowdownMorphism)
center_data(bl::ToricBlowdownMorphism)
center_unnormalized(bl::ToricBlowdownMorphism)
exceptional_prime_divisor(bl::ToricBlowdownMorphism)
underlying_morphism(bl::ToricBlowupMorphism)
index_of_new_ray(bl::ToricBlowupMorphism)
center_data(bl::ToricBlowupMorphism)
center_unnormalized(bl::ToricBlowupMorphism)
exceptional_prime_divisor(bl::ToricBlowupMorphism)
```
Based on `underlying_morphism`, also the following attributes of toric
morphisms are supported for toric blowups:
- `grid_morphism(bl::ToricBlowdownMorphism)`,
- `morphism_on_torusinvariant_weil_divisor_group(bl::ToricBlowdownMorphism)`,
- `morphism_on_torusinvariant_cartier_divisor_group(bl::ToricBlowdownMorphism)`,
- `morphism_on_class_group(bl::ToricBlowdownMorphism)`,
- `morphism_on_picard_group(bl::ToricBlowdownMorphism)`.
- `grid_morphism(bl::ToricBlowupMorphism)`,
- `morphism_on_torusinvariant_weil_divisor_group(bl::ToricBlowupMorphism)`,
- `morphism_on_torusinvariant_cartier_divisor_group(bl::ToricBlowupMorphism)`,
- `morphism_on_class_group(bl::ToricBlowupMorphism)`,
- `morphism_on_picard_group(bl::ToricBlowupMorphism)`.
The total and strict transform of ideal sheaves along blowups, not
necessarily toric, can be computed:
```@docs
total_transform(f::AbsSimpleBlowdownMorphism, II::AbsIdealSheaf)
total_transform(f::AbsSimpleBlowupMorphism, II::AbsIdealSheaf)
```


Expand Down
4 changes: 2 additions & 2 deletions experimental/FTheoryTools/src/auxiliary.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@

_strict_transform(bd::AbsCoveredSchemeMorphism, II::AbsIdealSheaf) = strict_transform(bd, II)

function _strict_transform(bd::ToricBlowdownMorphism, II::ToricIdealSheafFromCoxRingIdeal)
function _strict_transform(bd::ToricBlowupMorphism, II::ToricIdealSheafFromCoxRingIdeal)

Check warning on line 465 in experimental/FTheoryTools/src/auxiliary.jl

View check run for this annotation

Codecov / codecov/patch

experimental/FTheoryTools/src/auxiliary.jl#L465 

Added line #L465 was not covered by tests
center_ideal = ideal_in_cox_ring(center_unnormalized(bd))
if (ngens(ideal_in_cox_ring(II)) != 1) || (all(in(gens(base_ring(center_ideal))), gens(center_ideal)) == false)
return strict_transform(bd, II)
Expand All @@ -487,7 +487,7 @@
return ideal_sheaf(domain(bd), strict_transform)
end

function _strict_transform(bd::ToricBlowdownMorphism, tate_poly::MPolyRingElem)
function _strict_transform(bd::ToricBlowupMorphism, tate_poly::MPolyRingElem)
S = cox_ring(domain(bd))
_e = gen(S, index_of_new_ray(bd))
g_list = string.(gens(S))
Expand Down
Loading
Loading