Version 1.2.0

[fingolfin]

Resolves #4211

[lgoettgens]

I think you messed up 1.2.0 with 0.12.0.

And just as stupid question since I don't remember how we did it the last few times: When do we branch off release-1.2? Before or after adapting the version?

[benlorenz]

And just as stupid question since I don't remember how we did it the last few times: When do we branch off release-1.2? Before or after adapting the version?

I usually created the release branch first and then merged the PR setting the version to the release version. But I guess bumping it first and then branching from the merge is also fine.
Once the branch is done the master should get 1.3.0-DEV.

I wrote down my process here: https://docs.oscar-system.org/stable/DeveloperDocumentation/release/

[fingolfin]

Yeah my plan is that as soon as as this is merged, we merge another PR setting the version to 1.3.0-DEV.

Or I could just put that commit in here right now and we "merge by rebase" (instead of squash or actual merge) to preserve both commits.

[thofma]

Thanks. I was not sure about the process with the branches (which is why I did not open the PR myself).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (84ad208) to head (cd4f52f).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4255   +/-   ##
=======================================
  Coverage   84.59%   84.60%           
=======================================
  Files         640      640           
  Lines       85126    85128    +2     
=======================================
+ Hits        72015    72019    +4     
+ Misses      13111    13109    -2     

see 1 file with indirect coverage changes

[fingolfin]

@benlorenz I assume you will create the branch, ok?

[benlorenz]

@benlorenz I assume you will create the branch, ok?

done: https://github.com/oscar-system/Oscar.jl/commits/release-1.2/
Edit: I also added branch protection rules.

[lgoettgens]

@benlorenz can you do the 1.3.0-DEV bump as well an commit it as the next thing on master?

[benlorenz]

@benlorenz can you do the 1.3.0-DEV bump as well an commit it as the next thing on master?

#4258

[benlorenz]

I regenerated the release notes for 1.2.0 with github since tagbot only showed the changes since the when 1.1.2 was created.