Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isomorphism(::Type{PermGroup}, ::WeylGroup) for some cases #4264

Merged
merged 7 commits into from
Nov 1, 2024

Better iso test

2286d23
Select commit
Loading
Failed to load commit list.
Merged

Add isomorphism(::Type{PermGroup}, ::WeylGroup) for some cases #4264

Better iso test
2286d23
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2024 in 0s

84.60% (-0.01%) compared to 852b6d1, passed because coverage increased by 0% when compared to adjusted base (84.60%)

View this Pull Request on Codecov

84.60% (-0.01%) compared to 852b6d1, passed because coverage increased by 0% when compared to adjusted base (84.60%)

Details

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (852b6d1) to head (2286d23).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
experimental/LieAlgebras/src/WeylGroup.jl 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4264      +/-   ##
==========================================
- Coverage   84.60%   84.60%   -0.01%     
==========================================
  Files         640      640              
  Lines       85128    85145      +17     
==========================================
+ Hits        72021    72034      +13     
- Misses      13107    13111       +4     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
experimental/LieAlgebras/test/WeylGroup-test.jl 97.77% <ø> (ø)
experimental/LieAlgebras/src/WeylGroup.jl 92.03% <89.28%> (-0.25%) ⬇️

... and 3 files with indirect coverage changes