Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and advances from the OSCAR session in Durham #4314

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

HechtiDerLachs
Copy link
Collaborator

This is a draft PR with the fixes and advances in code from the OSCAR session in Durham.

In the beginning this will comprise eventual small fixes for bugs found during the preparation of the material. Eventually, this will then be extended by new functionality implemented by people there.

fingolfin
fingolfin previously approved these changes Nov 15, 2024
@HechtiDerLachs HechtiDerLachs marked this pull request as draft November 15, 2024 14:17
@lgoettgens lgoettgens dismissed fingolfin’s stale review November 15, 2024 14:39

still WIP, with ongoing changes

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (2a8e01f) to head (6e4cf75).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4314      +/-   ##
==========================================
- Coverage   84.53%   84.49%   -0.05%     
==========================================
  Files         641      645       +4     
  Lines       85563    85589      +26     
==========================================
- Hits        72332    72319      -13     
- Misses      13231    13270      +39     
Files with missing lines Coverage Δ
...ebraicGeometry/Schemes/Divisors/AlgebraicCycles.jl 75.00% <100.00%> (-0.65%) ⬇️
...gebraicGeometry/Schemes/Divisors/CartierDivisor.jl 64.25% <100.00%> (-1.00%) ⬇️
.../AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl 80.41% <100.00%> (ø)

... and 20 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants