-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and advances from the OSCAR session in Durham #4314
Draft
HechtiDerLachs
wants to merge
28
commits into
oscar-system:master
Choose a base branch
from
HechtiDerLachs:Durham_2024
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
previously approved these changes
Nov 15, 2024
lgoettgens
dismissed
fingolfin’s stale review
November 15, 2024 14:39
still WIP, with ongoing changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4314 +/- ##
==========================================
- Coverage 84.53% 84.49% -0.05%
==========================================
Files 641 645 +4
Lines 85563 85589 +26
==========================================
- Hits 72332 72319 -13
- Misses 13231 13270 +39
|
Add functionality for canonical divisor.
self intersection via adjunction
example erroxe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR with the fixes and advances in code from the OSCAR session in Durham.
In the beginning this will comprise eventual small fixes for bugs found during the preparation of the material. Eventually, this will then be extended by new functionality implemented by people there.