Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and advances from the OSCAR session in Durham #4314

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Fixes and advances from the OSCAR session in Durham #4314

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
b0af8c6
Fix up for ideal sheaves.
HechtiDerLachs Nov 14, 2024
6e4cf75
Widen some signatures.
HechtiDerLachs Nov 15, 2024
63e3834
Initialize experimental folder for contributions from Durham.
HechtiDerLachs Nov 17, 2024
0d1e98b
Add first introductory notebook.
HechtiDerLachs Nov 17, 2024
1f3e270
Add data for an automorphism.
HechtiDerLachs Nov 17, 2024
03575a3
Add second part of the presentation.
HechtiDerLachs Nov 17, 2024
17cc1fb
Allow return of components of algebraic cycles as cycles.
HechtiDerLachs Nov 20, 2024
31e3b40
Implement the Weil Divisor of a rational function.
HechtiDerLachs Nov 20, 2024
be52898
Add functionality for canonical divisor
Nov 20, 2024
23d082b
Merge pull request #22 from StardustMath/Durham_2024
HechtiDerLachs Nov 21, 2024
1c23f54
Introduce method for moving divisors (WIP).
HechtiDerLachs Nov 21, 2024
2422acb
Extend irreducible_decomposition to gather components.
HechtiDerLachs Nov 21, 2024
14e610f
Fix up pullback of Cartier divisors.
HechtiDerLachs Nov 21, 2024
31c45d4
Disable tests for the moment.
HechtiDerLachs Nov 21, 2024
0229300
Fix up moving of divisors.
HechtiDerLachs Nov 21, 2024
f44252c
Add tests.
HechtiDerLachs Nov 21, 2024
ff6c7c2
self intersection via adjunction
Nov 21, 2024
967c6db
Merge pull request #23 from StardustMath/Durham_2024
HechtiDerLachs Nov 21, 2024
ba63725
added embedding function and example
Nov 21, 2024
95513cb
Merge branch 'Durham_2024' of github.com:HechtiDerLachs/Oscar.jl into…
Nov 21, 2024
b37b2a3
Merge pull request #24 from Erroxe/Durham_2024
HechtiDerLachs Nov 21, 2024
b0a2c91
Fix up signature of self_intersection...
HechtiDerLachs Nov 21, 2024
ad8230c
Merge branch 'secrect_Durham_stuff' into Durham_2024_mod
HechtiDerLachs Nov 21, 2024
fd8d930
WIP on debugging.
HechtiDerLachs Nov 22, 2024
a9a14b0
WIP [no ci].
HechtiDerLachs Nov 22, 2024
b16cf8f
Fix up irreducible_decomposition.
HechtiDerLachs Nov 24, 2024
3db78a0
Fix up moving of divisors, etc.
HechtiDerLachs Nov 24, 2024
2812957
Extend tests.
HechtiDerLachs Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ is_locally_prime(I::PrimeIdealSheafFromChart) = true

function is_equidimensional(I::AbsIdealSheaf; covering=default_covering(scheme(I)))
has_attribute(I, :is_equidimensional) && return get_attribute(I, :is_equidimensional)::Bool
has_attribute(I, :is_prime) && return get_attribute(I, :is_prime)::Bool
has_attribute(I, :is_prime) && get_attribute(I, :is_prime)::Bool && return true
local_dims = [dim(I(U)) for U in patches(covering) if !isone(I(U))]
length(local_dims) == 0 && return true # This only happens if I == OO(X)
d = first(local_dims)
Expand Down
Loading