Skip to content

Commit

Permalink
Merge pull request #479 from oscar-system/bl/arrbigobj
Browse files Browse the repository at this point in the history
bigobjectarray: fix conversion from polymake to julia
  • Loading branch information
benlorenz authored Mar 16, 2024
2 parents 921194d + f54b4aa commit fa913b1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Polymake"
uuid = "d720cf60-89b5-51f5-aff5-213f193123e7"
repo = "https://github.com/oscar-system/Polymake.jl.git"
version = "0.11.14"
version = "0.11.15"

[deps]
BinaryWrappers = "f01c122e-0ea1-4f85-ad8f-907073ad7a9f"
Expand Down
2 changes: 1 addition & 1 deletion src/polymake/julia.rules
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function classify_perl_pv($) {
if instanceof Polymake::Core::BigObject($pv);
return "pm::perl::BigObjectType"
if instanceof Polymake::Core::BigObjectType($pv);
return "pm::perl::Array<pm::perl::BigObject>"
return "pm::Array<pm::perl::BigObject>"
if instanceof Polymake::Core::BigObjectArray($pv);
# a plain perl string is also done here
return "std::string"
Expand Down
7 changes: 7 additions & 0 deletions test/perlobj.jl
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,13 @@
@test arr[1] isa Polymake.BigObject
@test arr[2] isa Polymake.BigObject
@test arr[1].N_VERTICES == 8

c = polytope.cross(3)
@test Polymake.polytope.free_sum_decomposition(c) isa Polymake.Array{Polymake.BigObject}
arr = Polymake.polytope.free_sum_decomposition(c)
@test length(arr) == 3
@test arr[1].CONE_DIM == 2
@test arr[3].CONE_DIM == 2
end


Expand Down

2 comments on commit fa913b1

@benlorenz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/103002

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.11.15 -m "<description of version>" fa913b1ef3da5ee7b6b959bd73c68737ea9ec21b
git push origin v0.11.15

Please sign in to comment.