Fixed file upload issue when having file or image fields using … #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AjaxCRUD. jquery.ajax-plugin.js was serializing data, whereas latest FormData interface allows file uploads.
|
The InlineAjax functionality is currently lacking any testing, that makes it very risky to merge any changes that touch that. So this PR will need to be held back until someone volunteers that part of the test suite (preferably in a separate PR so the current behaviour can properly be tested prior to merging this). |
|
I agree testing is definitely required. If I get some free time next week, I will try to cover it, but can't commit on it right now. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…InlineAjaxCRUD.
jquery.ajax-plugin.js was serializing data, whereas the latest FormData interface allows file uploads. FormData is supported on all latest browsers.
#125