Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin doesn't log stacktraces #375

Closed
Gaming32 opened this issue Dec 3, 2023 · 2 comments · Fixed by #379
Closed

Darwin doesn't log stacktraces #375

Gaming32 opened this issue Dec 3, 2023 · 2 comments · Fixed by #379

Comments

@Gaming32
Copy link
Contributor

Gaming32 commented Dec 3, 2023

Throwables passed into logging functions on Darwin platforms will not print a stacktrace. There is simply no code that uses the KLoggingEventBuilder.cause on Darwin. This could potentially be resolved with Kotlin's Throwable.stackTraceToString(), which is available on Darwin (and all platforms).
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

Thank you for reporting an issue. See the wiki for documentation and slack for questions.

@oshai
Copy link
Owner

oshai commented Dec 4, 2023

Would you like to create a pull request for this?

@Gaming32 Gaming32 mentioned this issue Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log marker and stacktrace on Darwin Gaming32/kotlin-logging
2 participants
@oshai @Gaming32