Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lang parameter handling #1055

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Improve lang parameter handling #1055

merged 2 commits into from
Mar 11, 2024

Conversation

ZakarFin
Copy link
Member

@ZakarFin ZakarFin commented Mar 8, 2024 •
edited
Loading

  • no longer throws an error when someone makes a call with lang=[foo
  • no longer allows setting lang= to empty
  • language will now always be one of the supported languages configured with oskari-ext.properties
  • when any other language is requested, the default language will be used
  • previously both CookieLocaleResolver and WebLocaleResolver set the oskari.language cookie (2 separate Set-Cookie headers with the same name on response). Removed WebLocaleResolver and replaced CookieLocaleResolver with a custom ValidatingCookieLocaleResolver

@ZakarFin ZakarFin added this to the 2.13.0 milestone Mar 8, 2024
@ZakarFin ZakarFin merged commit 28d6732 into oskariorg:develop Mar 11, 2024
2 checks passed
@ZakarFin ZakarFin deleted the lang-param branch March 11, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ZakarFin