Coordinate information to print page #906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZakarFin
reviewed
Jan 9, 2023
| @@ -137,6 +147,9 @@ public class PDF { | |||
| private static final String MARKER_COORD_SEPARATOR= "_"; | |||
|
|
|||
| private static final FilterFactory2 ff = CommonFactoryFinder.getFilterFactory2(null); | |||
|
|
|||
| private static final ResourceBundle rb = ResourceBundle.getBundle("messages"); | |||
There was a problem hiding this comment.
We should rename "messages" to something else to avoid confusion when theres another localization file set called messages. Maybe just rename to "print-messages"?
ZakarFin
reviewed
Jan 9, 2023
| stream.stroke(); | ||
| } | ||
|
|
||
| private static int[] getCornerCoords(PrintRequest request) { |
There was a problem hiding this comment.
We shouldn't round to int for all projections. Maybe just keep as is without rounding for now?
ZakarFin
reviewed
Jan 9, 2023
| float textY2 = textY - OFFSET_TEXT_Y; | ||
|
|
||
| String coords = rb.getString("coordinates.lower") + ": " + bottomLat + ", " + bottomLon; | ||
| String projection = "ETRS-TM35FIN" + " " + rb.getString("coordinates"); |
There was a problem hiding this comment.
We shouldn't hard-code "ETRS-TM35FIN". Get it from the messages based on projection with fallback to the EPSG-code.
ZakarFin
reviewed
Jan 10, 2023
| @@ -321,6 +336,79 @@ private static void drawTimeseriesTexts(PDPageContentStream stream, | |||
| x, OFFSET_TIME_IN_TIMESERIES_BOTTOM); | |||
| } | |||
|
|
|||
| private static void drawCornerCoords(PDPageContentStream stream, PrintRequest request, float x, float y, float mapHeight, float mapWidth, PDRectangle pageSize) | |||
There was a problem hiding this comment.
Page size isn't used so we can remove it from params:
Suggested change
| private static void drawCornerCoords(PDPageContentStream stream, PrintRequest request, float x, float y, float mapHeight, float mapWidth, PDRectangle pageSize) | |
| private static void drawCornerCoords(PDPageContentStream stream, PrintRequest request, float x, float y, float mapHeight, float mapWidth) |
Closed
|
Included in #1035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printed map now shows ETRS-TM35FIN coordinates on corners