Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024 data #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

2024 data #28

wants to merge 1 commit into from

Conversation

mtmail
Copy link
Contributor

@mtmail mtmail commented Sep 26, 2024

  • new patch.sh script
  • Use virtual python environment (Ubuntu 24 starts complaining when installing pip packages globally).
  • Don't install ogr, that package has nothing to to with GIS/GDAL
  • Round projection output in tests (already rounded in conversion script). Still on my local installations I get slightly different coordinates than in Ubuntu environment. I gave up debugging why.

@mtmail mtmail requested a review from lonvia September 26, 2024 15:02
lonvia
lonvia reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@lonvia lonvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Ubuntu, I'd rather go for a native install of python3-gdal instead of using a virtualenv but I guess that won't work for your MacOS setup.

README.md
```

2. Get the TIGER 2023 data. You will need the EDGES files
2. Get the TIGER 2034 data. You will need the EDGES files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's far in the future.

patch.sh
#/bin/bash

# The 1..45 line is way off
grep -v '45;1;all;Woodfall Rd;Middlesex;MA;02478' 25017.csv > 25017.csv.tmp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems an odd way to go about fixing the data. What is the problem here? Can we add a generic sanity check to the csv conversion instead which drops the offending line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't Woodfall Rd: https://wktmap.com/?38df26f8 and I made a manual SQL change after importing the 2023 data. I don't know how to automate that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering linestrings that are too short?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonvia lonvia lonvia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtmail @lonvia