Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beaker key generate should allow 12 or 24 words #88

Open
daniel-farina opened this issue Jul 20, 2022 · 4 comments
Open

beaker key generate should allow 12 or 24 words #88

daniel-farina opened this issue Jul 20, 2022 · 4 comments

Comments

@daniel-farina
Copy link
Contributor

  • Currently it only supports 24 words mnemonics.
    Example:
beaker key set test 'praise wagon resist capital oxygen bounce vivid jacket pool crime embody dress'
Error: Invalid phrase, if word length is not 24, please consider using 24-words mnemonic
Caused by:
    bip39 error
@iboss-ptk
Copy link
Collaborator

This is a bip32 lib limitation which has fixed entropy. I don't think it would make sense to support unless there is a strong case for it.

Let me know if you think otherwise.

@ValarDragon
Copy link
Member

Agreed, I also don't think the envisioned usage of beaker needs robust key management. Its just for test keys, and a 12 word restriction seems fine for rn to me.

Eventually we'll just get more key things as a shim over osmosisd presumably.

@iboss-ptk
Copy link
Collaborator

@ValarDragon FFI to Go might make sense down the road I think. So user doesn't need to install the whole osmosisd.

@daniel-farina
Copy link
Contributor Author

sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants