Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder images for places that do not have an image #19

Open
xavez opened this issue Aug 4, 2016 · 6 comments
Open

Placeholder images for places that do not have an image #19

xavez opened this issue Aug 4, 2016 · 6 comments
Assignees
Labels

Comments

@xavez
Copy link
Contributor

xavez commented Aug 4, 2016

We need to add a placeholder image for places that do not have a photo. Right now, it is hot linked. http://www.leuven.be/binaries/Stadhuis-CoprightLaylaAerts_tcm16-24398.jpg

This has major high priority, assigning @huhu1030 and @elroyK because we cannot just hotlink a copyrighted image. Please fix ASAP :)

@xavez xavez added the bug label Aug 4, 2016
@elroyK
Copy link
Contributor

elroyK commented Aug 4, 2016

There's already a placeholder for places without pictures, those with this exact picture have it as their related image in the DB I think, can @JasperDR confirm ?

@JasperDR
Copy link
Contributor

JasperDR commented Aug 4, 2016

That is correct, this can be changed in the DB by uploading another picture and putting that one in the DB. I'm already working on a function to return the images from backend.

@xavez
Copy link
Contributor Author

xavez commented Aug 4, 2016

Okay, I don’t know the technical details, what needs to happen is that we

  • Remove the current hot linked image
  • Replace it with a placeholder image we created

As soon as possible because there is a rights issue.

@elroyK
Copy link
Contributor

elroyK commented Aug 4, 2016

As long as the hot linked image is deleted from the DB, the placeholder will be applied :)

@JasperDR
Copy link
Contributor

JasperDR commented Aug 4, 2016

cleared 'photos' table from DB

@JasperDR JasperDR closed this as completed Aug 4, 2016
@xavez
Copy link
Contributor Author

xavez commented Aug 4, 2016

Great!

However, who thought it was a good idea to put a 1mb picture as a placeholder? This should be a couple of mb’s max.

Not considering the placeholder debacle fixed just yet ;)

https://leuvenleestapp.be/assets/img/placeholder_locations.jpg

@xavez xavez reopened this Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants