Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): Extend Identifier.toPurl() with handling for Bazel #9481

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

fviernau
Copy link
Member

See also 1.

@fviernau fviernau added the on hold Pull requests that cannot currently be merged label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.93%. Comparing base (1d5676f) to head (4606136).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
model/src/main/kotlin/utils/PurlExtensions.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9481      +/-   ##
============================================
- Coverage     67.93%   67.93%   -0.01%     
  Complexity     1289     1289              
============================================
  Files           249      249              
  Lines          8792     8794       +2     
  Branches        913      913              
============================================
+ Hits           5973     5974       +1     
- Misses         2433     2434       +1     
  Partials        386      386              
Flag Coverage Δ
funTest-docker 64.82% <ø> (ø)
funTest-non-docker 33.33% <0.00%> (-0.02%) ⬇️
test 35.76% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@@ -39,6 +39,7 @@ import org.ossreviewtoolkit.model.VcsType
fun Identifier.getPurlType() =
when (type.lowercase()) {
"bower" -> PurlType.BOWER
"bazel" -> PurlType.BAZEL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the alphabetical order

@fviernau fviernau requested a review from nnobelis November 22, 2024 08:58
@fviernau fviernau marked this pull request as ready for review November 22, 2024 08:58
@fviernau fviernau requested a review from a team as a code owner November 22, 2024 08:58
@sschuberth sschuberth removed the on hold Pull requests that cannot currently be merged label Nov 22, 2024
@sschuberth
Copy link
Member

See also 1.

While that PR is not merged yet, we're not making any explicit assumptions about it in here, so we should be good to go.

@sschuberth sschuberth enabled auto-merge (rebase) November 22, 2024 09:19
sschuberth
sschuberth previously approved these changes Nov 22, 2024
See also [1].

[1]: package-url/purl-spec#317

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@sschuberth sschuberth merged commit eeba28e into main Nov 22, 2024
22 of 23 checks passed
@sschuberth sschuberth deleted the to-purl-bazel branch November 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants