-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model): Extend Identifier.toPurl()
with handling for Bazel
#9481
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9481 +/- ##
============================================
- Coverage 67.93% 67.93% -0.01%
Complexity 1289 1289
============================================
Files 249 249
Lines 8792 8794 +2
Branches 913 913
============================================
+ Hits 5973 5974 +1
- Misses 2433 2434 +1
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@@ -39,6 +39,7 @@ import org.ossreviewtoolkit.model.VcsType | |||
fun Identifier.getPurlType() = | |||
when (type.lowercase()) { | |||
"bower" -> PurlType.BOWER | |||
"bazel" -> PurlType.BAZEL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the alphabetical order
d1bd006
to
21b0b5a
Compare
While that PR is not merged yet, we're not making any explicit assumptions about it in here, so we should be good to go. |
See also [1]. [1]: package-url/purl-spec#317 Signed-off-by: Frank Viernau <frank_viernau@epam.com>
21b0b5a
to
4606136
Compare
See also 1.