Thermistor Support #273
Thermistor Support #273
Conversation
There was a problem hiding this comment.
Should there be a thermistor-output under digital-output? It looks like the controller takes one in as a constructor parameter.
| public class ThermistorController { | ||
| private final ThermistorHelper thermistorHelper; | ||
| // Finalize (Still gathering my thoughts about this) | ||
| public ThermistorController(@Named("thermistor-input") DigitalInput sensorInput, @Named("thermistor-output") DigitalOutput sensorOutput){ |
There was a problem hiding this comment.
If the only endpoint is to read a value, do we need a DigitalOutput here? Or are there more endpoints planned that involve using the thermistor as an output for something?
There was a problem hiding this comment.
There is the actual functionality to be implemented in the helper class. Please ensure all planned features are fully developed and tested with actual hardware to confirm correct communication protocols. Once everything is finalized, we’ll be ready for a thorough review.
There was a problem hiding this comment.
This pull request implements support for the thermistor component; however, we currently lack the necessary Analog-to-Digital Converter (ADC) to test the hardware functionality effectively. To ensure thorough testing, I plan to prioritize ADC support in the next sprint and test the thermistor hardware in parallel.
Fixes #39
In order to integrate a thermistor as another component a Controller and Helper files are needed. In order for the Raspberry pi to integrate with our software the Application.yml file was adjusted to accommodate for the thermistor. The ThermistorHelper.java file was create to give the basic operations for the thermistor and the ThermistorController.java as a basic implementation of it.