To support PostgreSQL v15 #229

zwyan0 · 2022-06-09T08:22:48Z

To support PostgreSQL15

mikecaat

Thanks for your great work to support v15!

.github/workflows/build.yml

mikecaat

Thanks for your works!

Although I have some comments, it's ok after the RC version is released because it's trivial things.

Please add commit message the deatailed reason why you change the code because mainteners may change. For example, I think the following things are important.

why do we change to pg_backup_start()/pg_backup_stop() and the arguments are changed?
In my understanding, though the exclusive mode is remove, it just renames the function name and keeps the behavior because pg_rman already changed to use non-exclusive mode.
why the arc_srv_log_management.sh change the log_checkpoints = off? In my undersanding, the reason is that the test to check if the expected server logs are removed fails since the default value bacame 'on'. The checkpoint logs update the timestamp of server log files when executing the test, and it makes remove newer dummy server logs. To avoid the behavior, turn it off only when the tests are executed.

sql/show.sh

backup.c

mikecaat · 2022-07-21T05:48:15Z

Thanks!

・Renamed the functions pg_start_backup()/pg_stop_backup() to pg_backup_start()/pg_backup_stop() and change the arguments of pg_backup_stop() pg_rman already supported non-exclusive mode, so we just renamed the function names and change the arguments to keeps the behavior. ・Default log_checkpoints for regression test is off. In PostgreSQL15, the default value of log_checkpoints is on. The checkpoints are automatically triggered when regression tests are run. The test failed because some log files was updated timestamp and the wrong log was deleted. So, we turned this feature off before running the test.

zwyan0 · 2022-07-21T07:39:30Z

Thanks for your works!

Although I have some comments, it's ok after the RC version is released because it's trivial things.

Please add commit message the deatailed reason why you change the code because mainteners may change. For example, I think the following things are important.

why do we change to pg_backup_start()/pg_backup_stop() and the arguments are changed?
In my understanding, though the exclusive mode is remove, it just renames the function name and keeps the behavior because pg_rman already changed to use non-exclusive mode.

why the arc_srv_log_management.sh change the log_checkpoints = off? In my undersanding, the reason is that the test to check if the expected server logs are removed fails since the default value bacame 'on'. The checkpoint logs update the timestamp of server log files when executing the test, and it makes remove newer dummy server logs. To avoid the behavior, turn it off only when the tests are executed.

I changed commit message.

mikecaat

Sorry, I forgot to public my comments.

mikecaat · 2022-07-21T05:00:56Z

backup.c

-
-	/* 2nd argument is 'fast' (IOW, !smooth) */
+	/* 
+	 * Assumes PG version >= 8.4 


I think we don't need this comment because the function is renamed and we can't execute it to other versions.

I deleted this comment.

mikecaat · 2022-07-21T05:01:49Z

backup.c

+	/* 
+	 * Assumes PG version >= 8.4 
+	 * 
+	 * When second parameter is given as true, 


Do we really need this comment? I think the old comment is enough because we can see the description in the official postgresql documents

I deleted this comment.

mikecaat · 2022-07-21T05:03:10Z

backup.c

 * either the primary or standby server to successfully archive the last
 * needed WAL segment to be archived.  Returns once that's been done.
 *
- * As of PG version 9.6, pg_stop_backup() returns 2 more fields in addition
+ * As of PG version 9.6, pg_backup_stop() returns 2 more fields in addition


Do need to change the version from 9.6 to 15.0?

Please check if there are other messages related to other PG version.

I checked all files. And I think only this place need to change the version to 15.0.

backup.c

.github/workflows/build.yml

backup.c

zwyan0 · 2022-07-28T02:22:06Z

backup.c

 * either the primary or standby server to successfully archive the last
 * needed WAL segment to be archived.  Returns once that's been done.
 *
- * As of PG version 9.6, pg_stop_backup() returns 2 more fields in addition
+ * As of PG version from 15.0, pg_backup_stop() returns 2 more fields in addition


Delete the version number

I deleted this comment.

backup.c

* Add notes to take a backup at standby-site * Unify 'standby site' to 'standby-site' Co-authored-by: Masahiro Ikeda <masahiro.ikeda.us@hco.ntt.co.jp>

Previously, if the server has a tablespace and its path has PGDATA's path, the restore fails because mkdirs.sh doesn't work. For example, the following case fails to restore. * PGDATA path: /tmp/pgdata * tablespace path: /tmp/pgdata_tblspc So, this patch fixes the case. The root cause is the logic checking whether the file taking backup is in tablespace or PGDATA. Because it only considers their prefix, if the prefix path of tablespace is the same as PGDATA, it decides the file is in PGDATA. So, this patch changes the logic to check it has '/' after the prefix.

・Renamed the functions pg_start_backup()/pg_stop_backup() to pg_backup_start()/pg_backup_stop() and change the arguments of pg_backup_stop() pg_rman already supported non-exclusive mode, so we just renamed the function names and change the arguments to keeps the behavior. ・Default log_checkpoints for regression test is off. In PostgreSQL15, the default value of log_checkpoints is on. The checkpoints are automatically triggered when regression tests are run. The test failed because some log files was updated timestamp and the wrong log was deleted. So, we turned this feature off before running the test.

tdchi · 2022-12-05T09:29:07Z

Hello.
When will the pg_rman source be released to support PG15?

The following commit(17f7109) forgot to change the index of parameters although it adds a new parameter. It makes --hard-copy not work in restore. And there is no test code to check that the default option uses symbolic links. So add some test code and modified the manual about describe the -Z option.

zwyan0 · 2022-12-09T02:29:36Z

Hello. When will the pg_rman source be released to support PG15?

Hello.
I can't give you an exact time, but we will try to release it as soon as possible.

.github/workflows/build.yml

backup.c

・Renamed the functions pg_start_backup()/pg_stop_backup() to pg_backup_start()/pg_backup_stop() and change the arguments of pg_backup_stop() pg_rman already supported non-exclusive mode, so we just renamed the function names and change the arguments to keeps the behavior. ・Default log_checkpoints for regression test is off. In PostgreSQL15, the default value of log_checkpoints is on. The checkpoints are automatically triggered when regression tests are run. The test failed because some log files was updated timestamp and the wrong log was deleted. So, we turned this feature off before running the test.

…nto test_pg15_bate1

mikecaat reviewed Jun 9, 2022

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

mikecaat changed the title ~~For support PostgreSQL15~~ To support PostgreSQL v15 Jun 13, 2022

mikecaat reviewed Jun 13, 2022

View reviewed changes

sql/show.sh Outdated Show resolved Hide resolved

backup.c Outdated Show resolved Hide resolved

backup.c Outdated Show resolved Hide resolved

backup.c Outdated Show resolved Hide resolved

backup.c Outdated Show resolved Hide resolved

zwyan0 force-pushed the test_pg15_bate1 branch from 48eeec6 to b2c836c Compare July 21, 2022 01:13

zwyan0 added 4 commits July 21, 2022 16:30

changed build.yml

683524f

modityed the version

65f7203

change some comment

21fd0ec

zwyan0 force-pushed the test_pg15_bate1 branch from 3f36f46 to 21fd0ec Compare July 21, 2022 07:33

mikecaat reviewed Jul 25, 2022

View reviewed changes

changed some comment

c25ff60

zwyan0 commented Jul 28, 2022

View reviewed changes

zwyan0 and others added 11 commits July 28, 2022 13:49

Changed some comments

d466f13

Add notes to take a backup at standby-site (ossc-db#223)

66bc214

* Add notes to take a backup at standby-site * Unify 'standby site' to 'standby-site' Co-authored-by: Masahiro Ikeda <masahiro.ikeda.us@hco.ntt.co.jp>

Add documents of --pgconf-path parameter (ossc-db#222)

6958642

Add description for compress target to doc (ossc-db#235)

802c593

changed build.yml

a2c8872

modityed the version

2ce8c2e

change some comment

b1f359a

changed some comment

05456ba

Changed some comments

bdc7e73

mikecaat approved these changes Dec 12, 2022

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

backup.c Show resolved Hide resolved

Modified the build.yml and comment

9c2619c

zwyan0 added 11 commits December 12, 2022 10:48

merge

a0e488d

changed build.yml

412f68d

modityed the version

e1c8d89

change some comment

b5150d2

changed some comment

7587614

Changed some comments

0576a52

Modified the build.yml and comment

16f58d6

change some comment

90a0632

change comment

05a99fb

Merge branch 'test_pg15_bate1' of https://github.com/zwyan0/pg_rman i…

6ac01c2

…nto test_pg15_bate1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

To support PostgreSQL v15 #229

To support PostgreSQL v15 #229

zwyan0 commented Jun 9, 2022 •

edited

Loading

mikecaat left a comment

mikecaat left a comment •

edited

Loading

mikecaat commented Jul 21, 2022

zwyan0 commented Jul 21, 2022

mikecaat left a comment

mikecaat Jul 21, 2022

zwyan0 Jul 26, 2022

mikecaat Jul 21, 2022

zwyan0 Jul 26, 2022

mikecaat Jul 21, 2022

mikecaat Jul 21, 2022

zwyan0 Jul 27, 2022

zwyan0 Jul 28, 2022

zwyan0 Jul 28, 2022

tdchi commented Dec 5, 2022

zwyan0 commented Dec 9, 2022 •

edited

Loading

To support PostgreSQL v15 #229

Are you sure you want to change the base?

To support PostgreSQL v15 #229

Conversation

zwyan0 commented Jun 9, 2022 • edited Loading

mikecaat left a comment

Choose a reason for hiding this comment

mikecaat left a comment • edited Loading

Choose a reason for hiding this comment

mikecaat commented Jul 21, 2022

zwyan0 commented Jul 21, 2022

mikecaat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdchi commented Dec 5, 2022

zwyan0 commented Dec 9, 2022 • edited Loading

zwyan0 commented Jun 9, 2022 •

edited

Loading

mikecaat left a comment •

edited

Loading

zwyan0 commented Dec 9, 2022 •

edited

Loading