Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorecard doesn't detect OpenSSF Best Practices badge #4413

Closed
ivanoblomov opened this issue Nov 12, 2024 · 4 comments
Closed

Scorecard doesn't detect OpenSSF Best Practices badge #4413

ivanoblomov opened this issue Nov 12, 2024 · 4 comments
Labels
kind/bug Something isn't working

Comments

@ivanoblomov
Copy link

ivanoblomov commented Nov 12, 2024

Describe the bug
Scorecard doesn't detect the OpenSSF Best Practices badge for the project https://github.com/FoveaCentral/hit_counter.

Reproduction steps

  1. The project scores 0/10 even though the README has the badge and the Best Practices site has its report.

Expected behavior
The project should get a 5/10 because it has a passing badge.

Additional context
I don't think the case-sensitivity issue noted in #3466 (comment) is related since in this case all results are going to the camel-cased https://scorecard.dev/viewer/?uri=github.com/FoveaCentral/hit_counter and nothing ever went to the lowercased https://scorecard.dev/viewer/?uri=github.com/foveacentral/hit_counter.

As another data point, the badge is correctly detected for the sister project https://github.com/FoveaCentral/vaccinesignup since it has the expected score of 5.

The most obvious delta between the two projects is that the working one's default branch is main while the other is master. I had similar results with another project with a master branch.

@ivanoblomov ivanoblomov added the kind/bug Something isn't working label Nov 12, 2024
@spencerschrock
Copy link
Member

  1. The project scores 0/10 even though the README has the badge and the Best Practices site has its report.

Did you rename your repo? The bestpractice metadata has this for the project URL (which is different from github.com/FoveaCentral/hit_counter):

https://github.com/ivanoblomov/hit_counter

@ivanoblomov
Copy link
Author

@spencerschrock that's right. To enable 2FA, GitHub required us to move the repo to an organization.

@spencerschrock
Copy link
Member

Once you update the metadata in Best Practices, it should be detected.

@ivanoblomov
Copy link
Author

Doh, completely forgot that was user editable. That worked, cheers @spencerschrock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants