Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace core-maintainers with core-team #76

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

luigigubello
Copy link
Contributor

Try to solve #67

Signed-off-by: Luigi Gubello <luigi@pitch.io>
@luigigubello luigigubello force-pushed the luigigubello/improve-core-maintainers branch from 80ba04a to 80ff54d Compare February 16, 2024 16:22
Signed-off-by: Luigi Gubello <luigi.gubello@gmail.com>
@luigigubello
Copy link
Contributor Author

@eddie-knight almost ready, I need to update the documentation :)

@eddie-knight
Copy link
Contributor

Considering that this is a minor version release, I would go with deprecation rather than removal at this time. Then a later release can remove deprecated items. WDYT?

@eddie-knight
Copy link
Contributor

We should also make sure that any PR to modify the schema includes corresponding modifications to the spec. I can do that and push to this PR if that would help.

Signed-off-by: Luigi Gubello <luigi.gubello@gmail.com>
@luigigubello
Copy link
Contributor Author

  • Readded core-maintainers with a deprecation alert.
  • core-team is conditionally required
  • Added core-team in specification.md

specification.md Outdated Show resolved Hide resolved
Co-authored-by: Eddie Knight <knight@linux.com>
Signed-off-by: Luigi Gubello <27034386+luigigubello@users.noreply.github.com>
@eddie-knight
Copy link
Contributor

LGTM! @ me when you take this out of draft and I'm happy to approve

@luigigubello luigigubello marked this pull request as ready for review April 9, 2024 18:07
@eddie-knight eddie-knight merged commit 39f9d1c into main Apr 9, 2024
2 of 3 checks passed
@eddie-knight eddie-knight deleted the luigigubello/improve-core-maintainers branch April 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants