pySCG adding CWE-78 code and doc #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Helge Wehder <helge.wehder@ericsson.com>
gkunz
requested changes
Nov 6, 2024
Co-authored-by: Georg Kunz <georg.kunz@ericsson.com> Signed-off-by: myteron <myteron@gmail.com>
Co-authored-by: Georg Kunz <georg.kunz@ericsson.com> Signed-off-by: myteron <myteron@gmail.com>
Co-authored-by: Georg Kunz <georg.kunz@ericsson.com> Signed-off-by: myteron <myteron@gmail.com>
BartyBoi1128
reviewed
Nov 7, 2024
BartyBoi1128
reviewed
Nov 7, 2024
|
|
||
| ``` | ||
|
|
||
| Instead of listing files, the code in `noncompliant01.py` prints the first line of `/etc/passwd` on Linux or starts `net user` under Windows. |
There was a problem hiding this comment.
This seems to behave differently for me in Windows... we should discuss
There was a problem hiding this comment.
updated content to explain a bit more
BartyBoi1128
reviewed
Nov 7, 2024
addressed typos and phrasing comments by bart Signed-off-by: myteron <myteron@gmail.com>
Signed-off-by: myteron <myteron@gmail.com>
Signed-off-by: myteron <myteron@gmail.com>
gkunz
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I cannot test the Windows runtime behavior issue @BartyBoi1128 pointed out, but I am ok with the other changes.
BartyBoi1128
approved these changes
Nov 8, 2024
|
Got approval from Bart. This is part of #531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CWE-78 as part of #531
also building on top of discussion from #654