Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpOT-fast code error #5

Open
Sprate opened this issue Sep 14, 2021 · 0 comments
Open

SpOT-fast code error #5

Sprate opened this issue Sep 14, 2021 · 0 comments

Comments

@Sprate
Copy link

Sprate commented Sep 14, 2021

Hi, Ni Trieu. When I increase the expectedIntersection, I found two errors in your code.
1.In two choice hash, when you swap the bin positions of two values, their hash indexes should be reversed.
So in BalancedIndex.cpp, the above code might be append.

image

2.In MultiThread setting, when insert the final results into globalHash, you might forget to lock the thread in your code.
It happens in PrtySender.cpp line 252, the above code might be right.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant