JI-5465 state check for interactions #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otacke
requested changes
Sep 19, 2023
|
Thanks, good points above - initially I just tried to find the fastest way to accomplish it while trying to just keep it understandable, but I do agree that your suggestions make sense and would improve the code, so the latest commit should address them. |
|
"Quicker, easier, more seductive." No need to tell me, I am tempted too often myself :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are aimed to accomplish basically the same thing that was done here otacke/h5p-sort-paragraphs@03785a6, though I also needed to add the
resetAudiocalls to reset buttons' classes.