Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kubernetes API 'Forbidden' errors during update, being wrongly reported as errors on the resource #163

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

amitlicht
Copy link
Contributor

Description

This PR fixes an issue with handling Kubernetes API 'Forbidden' errors during update, which are being wrongly reported as errors in the logs and on the Kubernetes resource. These errors are expected during the normal workflow of a reconciler, e.g. when the resource in question is already being deleted. They should be caught and the flow should be requeued (similar to 'Conflict' errors).

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

…dating resources - should lead to requeue rather than be reported as error
@amitlicht amitlicht marked this pull request as ready for review September 22, 2024 12:43
@amitlicht amitlicht merged commit 35a9d9b into main Sep 22, 2024
8 of 9 checks passed
@amitlicht amitlicht deleted the amitlicht/forbidden_error_on_update branch September 22, 2024 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants