Use StrategicMergeFrom to update finalizers #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A possible race condition exists when deleting an object using foregroundDeletion. It is possible when deleting an object with children using foregroundDeletion, for the watcher to have a different knowledge of the finalizer list than the API server that receives the Patch request, i.e. the watcher sees the foregroundDeletion finalizer, but the server that accepts the patch request doesn't so it looks like it was added. Using StrategicMergeFrom creates a proper patch instead of replacing the list, which solves the issue.
Additionally, ignore errors for invalid patches while cleaning up.
References
Very similar bug: kubernetes/kubernetes#111643