Improves naming of default channel type.

CHANGELOG.md

@@ -3,9 +3,13 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
-## [Unreleased]
+## [0.3.0] - 2019-08-22
 ### Added
 - Adds support for creating and posting to public channels.
+- Adds support for specifying the default channel type to create.
+
+### Changed
+- Private, then public channels are searched before attempting to create a channel.
 
 ## [0.2.0] - 2019-08-08
 ### Added

README.md

@@ -104,7 +104,7 @@ This will result in message text such as the following:
 
 You can specify the channel type as public or private. This will be used when creating channels, or posting messages.
 
-Set the `channel_type` query parameter in the HTTP request, or use the `DEFAULT_CHANNEL_TYPE` environment variable.
+Set the `channel_type` query parameter in the HTTP request, or use the `DEFAULT_CREATE_CHANNEL_TYPE` environment variable.
 
 Valid values:
 
@@ -184,7 +184,7 @@ Configure the bot using the following environment variables.
 - HTTP_BIND_PORT (default 8080)
 - HTTP_BIND_HOST (default 0.0.0.0)
 - SLACK_CACHE_SECONDS - period to cache Slack objects like users and user groups (default 300)
-- DEFAULT_CHANNEL_TYPE (default 'private') - the default channel type if none is specified in the request
+- DEFAULT_CREATE_CHANNEL_TYPE (default 'private') - the default channel type to create if none is specified in the request
 
 ## Contributing
 

backends/slack/src/main/kotlin/com/gatehill/slackgateway/backend/slack/service/SlackOutboundMessageService.kt

@@ -49,7 +49,7 @@ class SlackOutboundMessageService @Inject constructor(
 
         } ?: run {
             // create the channel
-            val createChannelType = channelType ?: Settings.defaultChannelType
+            val createChannelType = channelType ?: Settings.defaultCreateChannelType
             logger.debug("Channel $channelName ($createChannelType) does not exist - creating")
             slackOperationsService.createChannel(channelName, createChannelType)
         }

core/src/main/kotlin/com/gatehill/slackgateway/config/Settings.kt

@@ -6,7 +6,7 @@ import com.gatehill.slackgateway.model.ChannelType
  * Core application settings.
  */
 object Settings : EnvironmentSettings() {
-    val defaultChannelType: ChannelType by lazy {
-        getenv("DEFAULT_CHANNEL_TYPE")?.let { ChannelType.parse(it) } ?: ChannelType.PRIVATE
+    val defaultCreateChannelType: ChannelType by lazy {
+        getenv("DEFAULT_CREATE_CHANNEL_TYPE")?.let { ChannelType.parse(it) } ?: ChannelType.PRIVATE
     }
 }

distro/src/main/kotlin/com/gatehill/slackgateway/bot/Main.kt

@@ -7,6 +7,6 @@ import com.gatehill.slackgateway.util.VersionUtil
 
 fun main(args: Array<String>) {
     println("Starting Slack Gateway [version ${VersionUtil.version}]")
-    println("Default channel type: ${Settings.defaultChannelType}")
+    println("Default channel type: ${Settings.defaultCreateChannelType}")
     Bootstrap.build(HttpModule(), SlackModule()).start()
 }

docker-compose.yml

@@ -11,5 +11,5 @@ services:
     environment:
       - SLACK_USER_TOKEN
       - SLACK_CHANNEL_MEMBERS
-      - DEFAULT_CHANNEL_TYPE
+      - DEFAULT_CREATE_CHANNEL_TYPE
       - JAVA_OPTS